refactor(api): make the domain types a public package

The domain types have lived in pkg/api/internal/types, with pkg/api
re-exporting them through alias shims. That was scaffolding so the
earlier splits (#1412, #1422, #1434, #1498) could move code without
requalifying every caller at the same time.

Those splits have landed, so the scaffolding comes down: types moves to
pkg/api/types and callers name it directly. That leaves pkg/api owning
just the database handle and the migrations, and the public admin and
runtime packages no longer expose internal domain types in their
signatures.

This commit is purely refactoring and shouldn't change any behavior.

Refs: #1375
Signed-off-by: Moustafa Moustafa <momousta@microsoft.com>

Author: Moustafa-Moustafa

backend/pkg/api/actions.go

@@ -4,18 +4,20 @@ import (
 	"testing"
 
 	"github.com/stretchr/testify/assert"
+
+	"github.com/flatcar/nebraska/backend/pkg/api/types"
 )
 
 func TestAddFlatcarAction(t *testing.T) {
 	a := newForTest(t)
 	defer a.Close()
 	as := adminSvc(a)
 
-	tTeam, _ := as.AddTeam(&Team{Name: "test_team"})
-	tApp, _ := as.AddApp(&Application{Name: "test_app", TeamID: tTeam.ID})
-	tPkg, _ := as.AddPackage(&Package{Type: PkgTypeFlatcar, URL: "http://sample.url/pkg", Version: "12.1.0", ApplicationID: tApp.ID})
+	tTeam, _ := as.AddTeam(&types.Team{Name: "test_team"})
+	tApp, _ := as.AddApp(&types.Application{Name: "test_app", TeamID: tTeam.ID})
+	tPkg, _ := as.AddPackage(&types.Package{Type: types.PkgTypeFlatcar, URL: "http://sample.url/pkg", Version: "12.1.0", ApplicationID: tApp.ID})
 
-	flatcarAction, err := as.AddFlatcarAction(&FlatcarAction{Event: "postinstall", Sha256: "fsdkjjfghsdakjfgaksdjfasd", PackageID: tPkg.ID})
+	flatcarAction, err := as.AddFlatcarAction(&types.FlatcarAction{Event: "postinstall", Sha256: "fsdkjjfghsdakjfgaksdjfasd", PackageID: tPkg.ID})
 	assert.NoError(t, err)
 
 	flatcarActionX, err := a.GetFlatcarAction(tPkg.ID)

backend/pkg/api/actions_test.go

@@ -3,7 +3,7 @@ package admin
 import (
 	"github.com/doug-martin/goqu/v9"
 
-	"github.com/flatcar/nebraska/backend/pkg/api/internal/types"
+	"github.com/flatcar/nebraska/backend/pkg/api/types"
 )
 
 // AddFlatcarAction registers the provided Omaha Flatcar action.

backend/pkg/api/activity.go

@@ -8,7 +8,7 @@ import (
 	"gopkg.in/guregu/null.v4"
 
 	"github.com/flatcar/nebraska/backend/pkg/api"
-	"github.com/flatcar/nebraska/backend/pkg/api/internal/types"
+	"github.com/flatcar/nebraska/backend/pkg/api/types"
 )
 
 // TestAdminActivityRouting verifies that the admin-side activity writer
@@ -42,7 +42,7 @@ func TestAdminActivityRouting(t *testing.T) {
 	assert.Equal(t, 0, runtimeCount, "admin writer must not write to the runtime activity table")
 
 	// Checking the admin activity is visible through the GetActivity as well.
-	entries, err := a.GetActivity(tTeam.ID, api.ActivityQueryParams{AppID: tApp.ID})
+	entries, err := a.GetActivity(tTeam.ID, types.ActivityQueryParams{AppID: tApp.ID})
 	require.NoError(t, err)
 	require.Len(t, entries, 1)
 	assert.Equal(t, types.ActivityChannelPackageUpdated, entries[0].Class, "admin activity must be visible through GetActivity/all_activity")

backend/pkg/api/admin/actions.go

@@ -7,7 +7,7 @@ import (
 	"github.com/doug-martin/goqu/v9"
 	"gopkg.in/guregu/null.v4"
 
-	"github.com/flatcar/nebraska/backend/pkg/api/internal/types"
+	"github.com/flatcar/nebraska/backend/pkg/api/types"
 )
 
 // AddApp registers the provided application.

backend/pkg/api/admin/activity_test.go

@@ -3,7 +3,7 @@ package admin
 import (
 	"github.com/doug-martin/goqu/v9"
 
-	"github.com/flatcar/nebraska/backend/pkg/api/internal/types"
+	"github.com/flatcar/nebraska/backend/pkg/api/types"
 )
 
 // AddChannel registers the provided channel.

backend/pkg/api/admin/applications.go

@@ -6,7 +6,7 @@ import (
 	"github.com/doug-martin/goqu/v9"
 	"github.com/google/uuid"
 
-	"github.com/flatcar/nebraska/backend/pkg/api/internal/types"
+	"github.com/flatcar/nebraska/backend/pkg/api/types"
 )
 
 // AddGroup registers the provided group.

backend/pkg/api/admin/channels.go

@@ -9,7 +9,7 @@ import (
 	"github.com/jmoiron/sqlx"
 
 	"github.com/flatcar/nebraska/backend/pkg/api/internal/dbreads"
-	"github.com/flatcar/nebraska/backend/pkg/api/internal/types"
+	"github.com/flatcar/nebraska/backend/pkg/api/types"
 )
 
 // checkMatchingArch returns an error if the arch does not match the channels

backend/pkg/api/admin/groups.go

@@ -6,7 +6,7 @@ import (
 	"github.com/doug-martin/goqu/v9"
 	"gopkg.in/guregu/null.v4"
 
-	"github.com/flatcar/nebraska/backend/pkg/api/internal/types"
+	"github.com/flatcar/nebraska/backend/pkg/api/types"
 )
 
 // AddChannelPackageFloor marks a package as a floor for a specific channel