Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide multi-arch runner images #179

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

darkdragon-001
Copy link

@darkdragon-001 darkdragon-001 commented Jan 23, 2024

This allows running the builder action on a native aarch64 runner which is much faster than using QEMU.

Based on the official docs.

Fixes #178

@darkdragon-001
Copy link
Author

@bilelmoussaoui could you please take a look?

@BigmenPixel0
Copy link
Contributor

Isn't it the same one?

@darkdragon-001
Copy link
Author

darkdragon-001 commented Feb 12, 2024

Isn't it the same one?

@BigmenPixel0 No. By default only the host architecture (x86_64 = amd64) is built. With these changes, this will also create an image for ARM (arm64) architecture.

@tytan652
Copy link
Contributor

tytan652 commented Feb 13, 2024

This does not work since the binfmt tooling needs to be run at runtime, so the setup-qemu-action still needs to be used to load/register binfmt.

@darkdragon-001
Copy link
Author

darkdragon-001 commented Feb 13, 2024

This does not work since the binfmt tooling needs to be run at runtime, so the setup-qemu-action still needs to be used to load/register binfmt.

What do you mean by "it will not work"? I built the images in my branch and am running them on an arm64 runner without problems.

This builds an arm64 images with all binaries using the arm64 version, so there is no need for binfmt on an arm64 runner.

@tytan652
Copy link
Contributor

tytan652 commented Feb 13, 2024

Sorry I misunderstood the PR, so it concerns a non-"wildly available" type of GitHub runner.

@darkdragon-001
Copy link
Author

darkdragon-001 commented Feb 14, 2024

Sorry I misunderstood the PR, so it concerns a non-"wildly available" type of GitHub runner.

Yes but it makes a huge difference. On https://github.com/nanu-c/axolotl this brings down the Flatpak build for arm64 from ~180min to ~20min (~14x speedup).

@darkdragon-001
Copy link
Author

@bilelmoussaoui @barthalion could you please take a look? This is working for me since quite some time, would be great to make this available for others as well.

@barthalion
Copy link
Member

Applied it at flathub-infra@79d4438.

@darkdragon-001
Copy link
Author

darkdragon-001 commented Feb 18, 2024

@barthalion The build in flathub-infra failed as it uses a different base image than this repository which is not available for arm64 yet.
I created flathub-infra/flatpak-builder-lint#298 to add this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aarch64 builder image
4 participants