Commit e172cb9
committed
Fix Linux/Windows bridge_example: skip 32-bit wheels + link Windows abi3 stub
Three CI failures from the previous run, all in the Linux + Windows
bridge_example matrix:
Linux:
Picked the wrong wheel — cibuildwheel produces both x86_64 AND i686
variants for ubuntu hosts, and `ls | head -n1` lands on
dart_bridge-*manylinux*_i686.whl alphabetically. pip then refuses
with "is not a supported wheel on this platform".
Fix: skip i686 in [tool.cibuildwheel] so only x86_64 ships. (Also
pre-emptively skip win32 for symmetry; Flet desktop is 64-bit only.)
Windows:
`LINK : fatal error LNK1104: cannot open file 'python314_d.lib'` —
find_package(Python3 ... Development.Module) picks the version-
specific debug-config import lib in Debug builds, but python-build-
standalone for Windows doesn't ship a Debug variant.
Fix: native/CMakeLists.txt — on WIN32, link against python3.lib (the
abi3 stable-ABI stub) directly. It's version-agnostic and has no
debug variant requirement, matching our Py_LIMITED_API choice in
dart_bridge.c.
iOS (separate flake):
iOS 3.14 passed in 12m26s but iOS 3.12 and 3.13 hung past 1 hour in
the "Package + run integration test" step. Adding timeout-minutes:
25 to both bridge_example_ios in ci.yml and test_bridge_example_ios
in the throwaway so future hangs fail loudly within 25 min instead
of consuming the 6-hour job default. Root cause TBD — likely a
CocoaPods/simulator zombie since one of three Python versions
succeeded.1 parent 446434e commit e172cb9
4 files changed
Lines changed: 16 additions & 2 deletions
File tree
- .github/workflows
- src/serious_python_bridge
- native
- python
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
269 | 269 | | |
270 | 270 | | |
271 | 271 | | |
| 272 | + | |
272 | 273 | | |
273 | 274 | | |
274 | 275 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
147 | 147 | | |
148 | 148 | | |
149 | 149 | | |
| 150 | + | |
150 | 151 | | |
151 | 152 | | |
152 | 153 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
22 | 32 | | |
23 | 33 | | |
24 | 34 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
0 commit comments