-
Notifications
You must be signed in to change notification settings - Fork 543
pipeline: inputs: mqtt: update mqtt input config with buffer_size defaults and payload_key examples #2283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…aults and payload_key examples. Fixes fluent#2282. Signed-off-by: Eric D. Schabell <[email protected]>
WalkthroughUpdated MQTT input documentation: standardized configuration keys to snake_case, added the missing Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
pipeline/inputs/mqtt.md (1)
17-20: Notes section: clarify non-JSON payload behavior.The notes are helpful but line 20 ("non-JSON payloads will fail to parse") could be more precise about the impact. Does the message get dropped, or does the entire connection fail?
Please clarify the error handling behavior: for example, "non-JSON payloads will cause the message to be dropped with a warning log."
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pipeline/inputs/mqtt.md(3 hunks)
🔇 Additional comments (3)
pipeline/inputs/mqtt.md (3)
22-24: TLS/SSL section appropriately added.Good addition to reference the Transport Security documentation. This follows the standard pattern used elsewhere in the Fluent Bit documentation.
61-89: Configuration examples: snake_case and Title_Case formatting is correct.The YAML example correctly uses snake_case (
payload_keyon line 68) and the conf format correctly uses Title_Case (Payload_Keyon line 84). Both examples properly demonstrate the newpayload_keyparameter as requested in the issue.
9-15: Verify that referenced documentation links are valid.The configuration table structure with snake_case keys and defaults is well-organized. However, ensure the relative links at line 15 (
../../administration/multithreading.md#inputs) and line 24 (../../administration/transport-security.md) point to existing documentation pages in the repository.
…iew comments. Signed-off-by: Eric D. Schabell <[email protected]>
|
AI review passed, merging. |
update mqtt input config with
buffer_sizedefaults andpayload_keyexamplesFixes #2282.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.