bug: Enabling Fluentd in values.yaml causes a Helm rendering error due to a missing or misconfigured fluentd.image value.

[onap4105]

Describe the issue

v3.4.0, update values.yaml set fluentd.enable -> true

fluentd:
enable: true
name: fluentd

$ helm template fluent-operator ./fluent-operator
Error: template: fluent-operator/templates/fluentd-fluentd.yaml:17:59: executing "fluent-operator/templates/fluentd-fluentd.yaml" at <.Values.fluentd.image>: nil pointer evaluating interface {}.fluentd

Use --debug flag to render out invalid YAML

To Reproduce

update values.yaml set fluentd.enable -> true

fluentd:
enable: true
name: fluentd

$ helm template fluent-operator ./fluent-operator
Error: template: fluent-operator/templates/fluentd-fluentd.yaml:17:59: executing "fluent-operator/templates/fluentd-fluentd.yaml" at <.Values.fluentd.image>: nil pointer evaluating interface {}.fluentd

Use --debug flag to render out invalid YAML

Expected behavior

run helm template successfully

Your Environment

- Fluent Operator version:v3.4.0
- Container Runtime:
- Operating system:
- Kernel version:

How did you install fluent operator?

helm

Additional context

No response

[onap4105]

There is a bug in fluentd-fluentd.yaml.

The template uses the scope {{- with .Values.fluentd }}, but within this block, it is incorrect to access .Values.fluentd.image in the line:

image: {{ template "fluent-operator.image" (tuple .Values.fluentd.image "") }}

Because the context inside the with block is already .Values.fluentd, you should access the image field directly as .image.

Please update the template to:

image: {{ template "fluent-operator.image" (tuple .image "") }}

This change ensures the image value is correctly referenced within the current scope.

[joshuabaird]

@onap4105 PR's welcome. Thank you!

[cw-Guo]

@onap4105 this has been fixed in #1643

[onap4105]

@onap4105 this has been fixed in #1643

Thanks!