changes per peer review comments

Author: jhulick

charts/fluent-bit/templates/daemonset.yaml

@@ -27,11 +27,7 @@ spec:
   template:
     metadata:
       labels:
-        {{- if .Values.verbosePodLabels.enabled }}
-          {{- include "fluent-bit.verbosePodLabels" . | nindent 8 }}
-        {{- else }}
-          {{- include "fluent-bit.selectorLabels" . | nindent 8 }}
-        {{- end }}
+        {{- include (ternary "fluent-bit.verbosePodLabels" "fluent-bit.selectorLabels" .Values.verbosePodLabels)  . | nindent 8 }}
         {{- with .Values.podLabels }}
         {{- toYaml . | nindent 8 }}
         {{- end }}

charts/fluent-bit/templates/deployment.yaml

@@ -30,11 +30,7 @@ spec:
   template:
     metadata:
       labels:
-      {{- if .Values.verbosePodLabels.enabled }}
-        {{- include "fluent-bit.verbosePodLabels" . | nindent 8 }}
-      {{- else }}
-        {{- include "fluent-bit.selectorLabels" . | nindent 8 }}
-      {{- end }}
+      {{- include (ternary "fluent-bit.verbosePodLabels" "fluent-bit.selectorLabels" .Values.verbosePodLabels)  . | nindent 8 }}
       {{- with .Values.podLabels }}
         {{- toYaml . | nindent 8 }}
       {{- end }}

charts/fluent-bit/values.yaml

@@ -303,8 +303,7 @@ podAnnotations: {}
 podLabels: {}
 
 # adds app.kubernetes.io/version label to pods for istio required labels
-verbosePodLabels:
-  enabled: false
+verbosePodLabels: false
 
 ## How long (in seconds) a pods needs to be stable before progressing the deployment
 ##