[CQ] mark LOGs @NotNull (#8193)

`LOG` objects are statically initialized and sure to be not-null.
Annotating them all quiets downstream unsafe access warnings.

---

- [x] I’ve reviewed the contributor guide and applied the relevant
portions to this PR.

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor
guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview)
for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before
creating a PR.
- Dart contributions to our repos should follow the [Dart style
guide](https://dart.dev/guides/language/effective-dart) and use `dart
format`.
- Java and Kotlin contributions should strive to follow Java and Kotlin
best practices
([discussion](#8098)).
</details>

Author: pq

flutter-idea/src/io/flutter/FlutterInitializer.java

@@ -69,7 +69,7 @@
  * may run when a project is being imported.
  */
 public class FlutterInitializer implements StartupActivity {
-  private static final Logger LOG = Logger.getInstance(FlutterInitializer.class);
+  private static final @NotNull Logger LOG = Logger.getInstance(FlutterInitializer.class);
 
   private boolean toolWindowsInitialized = false;
 

flutter-idea/src/io/flutter/actions/FlutterDoctorAction.java

@@ -25,7 +25,7 @@
 
 public class FlutterDoctorAction extends FlutterSdkAction {
 
-  private static final Logger LOG = Logger.getInstance(FlutterDoctorAction.class);
+  private static final @NotNull Logger LOG = Logger.getInstance(FlutterDoctorAction.class);
 
   public void startCommand(@NotNull Project project, @NotNull FlutterSdk sdk, @Nullable PubRoot root) {
     sdk.flutterDoctor().startInConsole(project);

flutter-idea/src/io/flutter/analytics/UnifiedAnalytics.java

@@ -28,7 +28,7 @@
  * Facilitates sending information to unified analytics.
  */
 public class UnifiedAnalytics {
-  private static final Logger LOG = Logger.getInstance(UnifiedAnalytics.class);
+  private static final @NotNull Logger LOG = Logger.getInstance(UnifiedAnalytics.class);
 
   @Nullable Boolean enabled = null;
   final Project project;

flutter-idea/src/io/flutter/android/AndroidSdk.java

@@ -29,7 +29,7 @@
  * A wrapper around an Android SDK on disk.
  */
 public class AndroidSdk {
-  private static final Logger LOG = Logger.getInstance(AndroidSdk.class);
+  private static final @NotNull Logger LOG = Logger.getInstance(AndroidSdk.class);
 
   @Nullable
   public static AndroidSdk createFromProject(@NotNull Project project) {

flutter-idea/src/io/flutter/bazel/PluginConfig.java

@@ -299,5 +299,5 @@ public int hashCode() {
   }
 
   private static final Gson GSON = new Gson();
-  private static final Logger LOG = Logger.getInstance(PluginConfig.class);
+  private static final @NotNull Logger LOG = Logger.getInstance(PluginConfig.class);
 }

flutter-idea/src/io/flutter/bazel/WorkspaceCache.java

@@ -178,5 +178,5 @@ private void notifyListeners() {
     }
   }
 
-  private static final Logger LOG = Logger.getInstance(WorkspaceCache.class);
+  private static final @NotNull Logger LOG = Logger.getInstance(WorkspaceCache.class);
 }

flutter-idea/src/io/flutter/editor/FlutterColors.java

@@ -17,7 +17,7 @@
 import java.util.Properties;
 
 public class FlutterColors {
-  private static final Logger LOG = Logger.getInstance(FlutterColors.class);
+  private static final @NotNull Logger LOG = Logger.getInstance(FlutterColors.class);
 
   public static class FlutterColor {
     @NotNull

flutter-idea/src/io/flutter/editor/FlutterCupertinoColors.java

@@ -17,7 +17,7 @@
 import java.util.Properties;
 
 public class FlutterCupertinoColors {
-  private static final Logger LOG = Logger.getInstance(FlutterCupertinoColors.class);
+  private static final @NotNull Logger LOG = Logger.getInstance(FlutterCupertinoColors.class);
 
   private static final Properties colors;
 

flutter-idea/src/io/flutter/editor/FlutterCupertinoIcons.java

@@ -8,13 +8,14 @@
 import com.intellij.openapi.diagnostic.Logger;
 import com.intellij.openapi.util.IconLoader;
 import io.flutter.FlutterUtils;
+import org.jetbrains.annotations.NotNull;
 
 import javax.swing.*;
 import java.io.IOException;
 import java.util.Properties;
 
 public class FlutterCupertinoIcons {
-  private static final Logger LOG = Logger.getInstance(FlutterCupertinoIcons.class);
+  private static final @NotNull Logger LOG = Logger.getInstance(FlutterCupertinoIcons.class);
 
   private static final Properties icons;
 

flutter-idea/src/io/flutter/editor/FlutterIconLineMarkerProvider.java

@@ -49,7 +49,7 @@ public class FlutterIconLineMarkerProvider extends LineMarkerProviderDescriptor
 
   public static final Map<String, Set<String>> KnownPaths = new HashMap<>();
   private static final Map<String, String> BuiltInPaths = new HashMap<>();
-  private static final Logger LOG = Logger.getInstance(FlutterIconLineMarkerProvider.class);
+  private static final @NotNull Logger LOG = Logger.getInstance(FlutterIconLineMarkerProvider.class);
   private static final String MaterialRelativeAssetPath = "/bin/cache/artifacts/material_fonts/MaterialIcons-Regular.otf";
   private static final String MaterialRelativeIconsPath = "/packages/flutter/lib/src/material/icons.dart";
   private static final String CupertinoRelativeAssetPath = "/assets/CupertinoIcons.ttf";

flutter-idea/src/io/flutter/editor/FlutterMaterialIcons.java

@@ -8,13 +8,14 @@
 import com.intellij.openapi.diagnostic.Logger;
 import com.intellij.openapi.util.IconLoader;
 import io.flutter.FlutterUtils;
+import org.jetbrains.annotations.NotNull;
 
 import javax.swing.*;
 import java.io.IOException;
 import java.util.Properties;
 
 public class FlutterMaterialIcons {
-  private static final Logger LOG = Logger.getInstance(FlutterMaterialIcons.class);
+  private static final @NotNull Logger LOG = Logger.getInstance(FlutterMaterialIcons.class);
 
   private static final Properties icons;
 

flutter-idea/src/io/flutter/jxbrowser/EmbeddedBrowserEngine.java

@@ -12,6 +12,7 @@
 import com.teamdev.jxbrowser.engine.Engine;
 import com.teamdev.jxbrowser.engine.EngineOptions;
 import com.teamdev.jxbrowser.engine.PasswordStore;
+import org.jetbrains.annotations.NotNull;
 
 import java.io.File;
 import java.nio.file.Paths;
@@ -20,7 +21,7 @@
 import static com.teamdev.jxbrowser.engine.RenderingMode.OFF_SCREEN;
 
 public class EmbeddedBrowserEngine {
-  private static final Logger LOG = Logger.getInstance(EmbeddedBrowserEngine.class);
+  private static final @NotNull Logger LOG = Logger.getInstance(EmbeddedBrowserEngine.class);
   private final Engine engine;
 
   public static EmbeddedBrowserEngine getInstance() {
@@ -46,7 +47,8 @@ public EmbeddedBrowserEngine() {
     Engine temp;
     try {
       temp = Engine.newInstance(options);
-    } catch (Exception ex) {
+    }
+    catch (Exception ex) {
       temp = null;
       LOG.info(ex);
     }
@@ -59,7 +61,8 @@ public boolean canExitApplication() {
           if (engine != null && !engine.isClosed()) {
             engine.close();
           }
-        } catch (Exception ex) {
+        }
+        catch (Exception ex) {
           LOG.info(ex);
         }
         return true;

flutter-idea/src/io/flutter/jxbrowser/EmbeddedJxBrowser.java

@@ -49,7 +49,7 @@ class EmbeddedJxBrowserTab implements EmbeddedTab {
   private Browser browser;
   private Zoom zoom;
   private final ZoomLevelSelector zoomSelector = new ZoomLevelSelector();
-  private static final Logger LOG = Logger.getInstance(EmbeddedJxBrowserTab.class);
+  private static final @NotNull Logger LOG = Logger.getInstance(EmbeddedJxBrowserTab.class);
 
   public EmbeddedJxBrowserTab(Engine engine) {
     this.engine = engine;
@@ -122,7 +122,7 @@ public JComponent getTabComponent(ContentManager contentManager) {
 }
 
 public class EmbeddedJxBrowser extends EmbeddedBrowser {
-  private static final Logger LOG = Logger.getInstance(JxBrowserManager.class);
+  private static final @NotNull Logger LOG = Logger.getInstance(JxBrowserManager.class);
   private static final String INSTALLATION_IN_PROGRESS_LABEL = "Installing JxBrowser...";
   private static final String INSTALLATION_TIMED_OUT_LABEL =
     "Waiting for JxBrowser installation timed out. Restart your IDE to try again.";
@@ -181,7 +181,8 @@ public Logger logger() {
     if (engine == null) {
       showMessageWithUrlLink(jxBrowserErrorMessage(), contentManager);
       return null;
-    } else {
+    }
+    else {
       return new EmbeddedJxBrowserTab(engine);
     }
   }
@@ -210,7 +211,7 @@ public Logger logger() {
   private @Nullable String jxBrowserErrorFromFailedReason(@Nullable InstallationFailedReason failedReason) {
     if (failedReason == null) return null;
     final FailureType failureType = failedReason.failureType;
-    if (failureType == null)  return null;
+    if (failureType == null) return null;
     return switch (failureType) {
       case SYSTEM_INCOMPATIBLE -> "System is incompatible with JX Browser";
       case FILE_DOWNLOAD_FAILED -> "JX Browser file download failed";
@@ -220,7 +221,6 @@ public Logger logger() {
       case CLASS_LOAD_FAILED -> "JX Browser class load failed";
       case CLASS_NOT_FOUND -> "JX Browser class not found";
     };
-
   }
 
   private void manageJxBrowserDownload(ContentManager contentManager) {
@@ -234,7 +234,8 @@ else if (jxBrowserStatus.equals(JxBrowserStatus.INSTALLATION_IN_PROGRESS)) {
     }
     else if (jxBrowserStatus.equals(JxBrowserStatus.INSTALLATION_FAILED)) {
       handleJxBrowserInstallationFailed(contentManager);
-    } else if (jxBrowserStatus.equals(JxBrowserStatus.NOT_INSTALLED) || jxBrowserStatus.equals(JxBrowserStatus.INSTALLATION_SKIPPED)) {
+    }
+    else if (jxBrowserStatus.equals(JxBrowserStatus.NOT_INSTALLED) || jxBrowserStatus.equals(JxBrowserStatus.INSTALLATION_SKIPPED)) {
       jxBrowserManager.setUp(project.getName());
       handleJxBrowserInstallationInProgress(contentManager);
     }
@@ -269,9 +270,11 @@ protected void handleUpdatedJxBrowserStatusOnEventThread(JxBrowserStatus jxBrows
   protected void handleUpdatedJxBrowserStatus(JxBrowserStatus jxBrowserStatus, ContentManager contentManager) {
     if (Objects.equals(jxBrowserStatus, JxBrowserStatus.INSTALLED)) {
       return;
-    } else if (jxBrowserStatus.equals(JxBrowserStatus.INSTALLATION_FAILED)) {
+    }
+    else if (jxBrowserStatus.equals(JxBrowserStatus.INSTALLATION_FAILED)) {
       handleJxBrowserInstallationFailed(contentManager);
-    } else {
+    }
+    else {
       // newStatus can be null if installation is interrupted or stopped for another reason.
       showMessageWithUrlLink(INSTALLATION_WAIT_FAILED, contentManager);
     }
@@ -285,7 +288,8 @@ protected void handleJxBrowserInstallationFailed(ContentManager contentManager)
     if (!jxBrowserUtils.licenseIsSet()) {
       // If the license isn't available, allow the user to open the equivalent page in a non-embedded browser window.
       inputs.add(new LabelInput("The JxBrowser license could not be found."));
-    } else if (latestFailureReason != null && Objects.equals(latestFailureReason.failureType, FailureType.SYSTEM_INCOMPATIBLE)) {
+    }
+    else if (latestFailureReason != null && Objects.equals(latestFailureReason.failureType, FailureType.SYSTEM_INCOMPATIBLE)) {
       // If we know the system is incompatible, skip retry link and offer to open in browser.
       inputs.add(new LabelInput(latestFailureReason.detail));
     }

flutter-idea/src/io/flutter/logging/DiagnosticsNode.java

@@ -45,7 +45,7 @@
  * also available via the getValue() method.
  */
 public class DiagnosticsNode {
-  private static final Logger LOG = Logger.getInstance(DiagnosticsNode.class);
+  private static final @NotNull Logger LOG = Logger.getInstance(DiagnosticsNode.class);
 
   private static final CustomIconMaker iconMaker = new CustomIconMaker();
 

flutter-idea/src/io/flutter/logging/FlutterConsoleLogManager.java

@@ -56,7 +56,7 @@
  * console.
  */
 public class FlutterConsoleLogManager {
-  private static final Logger LOG = Logger.getInstance(FlutterConsoleLogManager.class);
+  private static final @NotNull Logger LOG = Logger.getInstance(FlutterConsoleLogManager.class);
 
   private static final String consolePreferencesSetKey = "io.flutter.console.preferencesSet";
   private static final String DEEP_LINK_GROUP_ID = "deeplink";

flutter-idea/src/io/flutter/module/FlutterModuleBuilder.java

@@ -55,7 +55,7 @@
 import static java.util.Arrays.asList;
 
 public class FlutterModuleBuilder extends ModuleBuilder {
-  private static final Logger LOG = Logger.getInstance(FlutterModuleBuilder.class);
+  private static final @NotNull Logger LOG = Logger.getInstance(FlutterModuleBuilder.class);
 
   protected FlutterModuleWizardStep myStep;
   private FlutterCreateAdditionalSettingsFields mySettingsFields;

flutter-idea/src/io/flutter/project/ProjectWatch.java

@@ -87,5 +87,5 @@ private void fireEvent() {
     }
   }
 
-  private static final Logger LOG = Logger.getInstance(ProjectWatch.class);
+  private static final @NotNull Logger LOG = Logger.getInstance(ProjectWatch.class);
 }

flutter-idea/src/io/flutter/run/FlutterDebugProcess.java

@@ -42,7 +42,7 @@
  * when not debugging in order to support hot reload.)
  */
 public class FlutterDebugProcess extends DartVmServiceDebugProcess {
-  private static final Logger LOG = Logger.getInstance(FlutterDebugProcess.class);
+  private static final @NotNull Logger LOG = Logger.getInstance(FlutterDebugProcess.class);
 
   private final @NotNull FlutterApp app;
 
@@ -55,7 +55,7 @@ public FlutterDebugProcess(@NotNull FlutterApp app,
     super(executionEnvironment, session, executionResult, dartUrlResolver, app.getConnector(), mapper);
     this.app = app;
   }
-  
+
   @Override
   protected void onVmConnected(@NotNull VmService vmService) {
     app.setFlutterDebugProcess(this);

flutter-idea/src/io/flutter/run/FlutterPositionMapper.java

@@ -40,7 +40,7 @@
  * Used when setting breakpoints, stepping through code, and so on while debugging.
  */
 public class FlutterPositionMapper implements DartVmServiceDebugProcess.PositionMapper {
-  private static final Logger LOG = Logger.getInstance(FlutterPositionMapper.class);
+  private static final @NotNull Logger LOG = Logger.getInstance(FlutterPositionMapper.class);
 
   /**
    * This Project can't be non-null as we set it to null {@link #shutdown()} so the Project isn't held onto.

flutter-idea/src/io/flutter/run/FlutterReloadManager.java

@@ -80,7 +80,7 @@
  * Handle the mechanics of performing a hot reload on file save.
  */
 public class FlutterReloadManager {
-  private static final Logger LOG = Logger.getInstance(FlutterReloadManager.class);
+  private static final @NotNull Logger LOG = Logger.getInstance(FlutterReloadManager.class);
 
   private static final Map<String, NotificationGroup> toolWindowNotificationGroups = new HashMap<>();
 

flutter-idea/src/io/flutter/run/LaunchState.java

@@ -463,5 +463,5 @@ public static ProcessHandler getRunningAppProcess(RunConfig config) {
 
   private static final Key<RunConfig> FLUTTER_RUN_CONFIG_KEY = new Key<>("FLUTTER_RUN_CONFIG_KEY");
 
-  private static final Logger LOG = Logger.getInstance(LaunchState.class);
+  private static final @NotNull Logger LOG = Logger.getInstance(LaunchState.class);
 }

flutter-idea/src/io/flutter/run/OpenDevToolsAction.java

@@ -27,7 +27,7 @@
 import java.util.Objects;
 
 public class OpenDevToolsAction extends DumbAwareAction {
-  private static final Logger LOG = Logger.getInstance(OpenDevToolsAction.class);
+  private static final @NotNull Logger LOG = Logger.getInstance(OpenDevToolsAction.class);
   private static final String title = "Open Flutter DevTools in Browser";
   private final @Nullable ObservatoryConnector myConnector;
   private final Computable<Boolean> myIsApplicable;
@@ -92,7 +92,7 @@ public void actionPerformed(@NotNull final AnActionEvent event) {
         .setIdeFeature(DevToolsIdeFeature.RUN_CONSOLE)
         .build()
         .getUrlString();
-      BrowserLauncher.getInstance().browse(devToolsUrl,null);
+      BrowserLauncher.getInstance().browse(devToolsUrl, null);
     });
   }
 }

flutter-idea/src/io/flutter/run/SdkFields.java

@@ -40,7 +40,7 @@
  * Fields used when launching an app using the Flutter SDK (non-bazel).
  */
 public class SdkFields {
-  private static final Logger LOG = Logger.getInstance(SdkFields.class);
+  private static final @NotNull Logger LOG = Logger.getInstance(SdkFields.class);
   private @Nullable String filePath;
   private @Nullable String buildFlavor;
   private @Nullable String additionalArgs;

flutter-idea/src/io/flutter/run/SdkRunConfig.java

@@ -59,7 +59,7 @@
 public class SdkRunConfig extends LocatableConfigurationBase<LaunchState>
   implements LaunchState.RunConfig, RefactoringListenerProvider, RunConfigurationWithSuppressedDefaultRunAction {
 
-  private static final Logger LOG = Logger.getInstance(SdkRunConfig.class);
+  private static final @NotNull Logger LOG = Logger.getInstance(SdkRunConfig.class);
   private boolean firstRun = true;
 
   private @NotNull SdkFields fields = new SdkFields();

flutter-idea/src/io/flutter/run/bazel/BazelFields.java

@@ -52,7 +52,7 @@
  * This class is immutable.
  */
 public class BazelFields {
-  private static final Logger LOG = Logger.getInstance(BazelFields.class);
+  private static final @NotNull Logger LOG = Logger.getInstance(BazelFields.class);
 
   /**
    * The Bazel target or Dart file to invoke.

flutter-idea/src/io/flutter/run/bazelTest/BazelTestRunner.java

@@ -54,7 +54,7 @@
  * The Bazel version of the {@link FlutterTestRunner}. Runs a Bazel Flutter test configuration in the debugger.
  */
 public class BazelTestRunner extends GenericProgramRunner {
-  private static final Logger LOG = Logger.getInstance(BazelTestRunner.class);
+  private static final @NotNull Logger LOG = Logger.getInstance(BazelTestRunner.class);
 
   @NotNull
   @Override
@@ -121,17 +121,17 @@ private static final class Connector implements ObservatoryConnector {
 
     public Connector(ProcessHandler handler, Project project) {
       Workspace workspace = WorkspaceCache.getInstance(project).get();
-      assert(workspace != null);
+      assert (workspace != null);
       String configWarningPrefix = workspace.getConfigWarningPrefix();
       listener = new ProcessAdapter() {
         @Override
         public void onTextAvailable(@NotNull ProcessEvent event, @NotNull Key outputType) {
           final String text = event.getText();
           if (configWarningPrefix != null && text.startsWith(configWarningPrefix)) {
             FlutterMessages.showWarning(
-                    "Configuration warning",
-                    UrlUtils.generateHtmlFragmentWithHrefTags(text.substring(configWarningPrefix.length())),
-                    null
+              "Configuration warning",
+              UrlUtils.generateHtmlFragmentWithHrefTags(text.substring(configWarningPrefix.length())),
+              null
             );
           }
 

flutter-idea/src/io/flutter/run/coverage/FlutterCoverageProgramRunner.java

@@ -35,7 +35,7 @@
 import java.nio.file.Paths;
 
 public class FlutterCoverageProgramRunner extends GenericProgramRunner<RunnerSettings> {
-  private static final Logger LOG = Logger.getInstance(FlutterCoverageProgramRunner.class.getName());
+  private static final @NotNull Logger LOG = Logger.getInstance(FlutterCoverageProgramRunner.class.getName());
 
   private static final String ID = "FlutterCoverageProgramRunner";
   private ProcessHandler handler;

flutter-idea/src/io/flutter/run/coverage/FlutterCoverageRunner.java

@@ -19,7 +19,7 @@
 
 public class FlutterCoverageRunner extends CoverageRunner {
   private static final String ID = "FlutterCoverageRunner";
-  private static final Logger LOG = Logger.getInstance(FlutterCoverageRunner.class.getName());
+  private static final @NotNull Logger LOG = Logger.getInstance(FlutterCoverageRunner.class.getName());
 
   @Nullable
   @Override