Skip to content

Commit 9bd3842

Browse files
authored
[CQ] remove FlutterCreateAdditionalSettingsField deadcode (#8207)
Following up on a TODO from Steve to remove an unused method and callers. Interestingly, `FlutterModuleGroup` seems entirely unused. It's meant to: ``` // Define a group of Flutter project types for use in Android Studio 4.2 and later. ``` Steve warns: ``` // TODO (messick) DO NOT delete this during post-4.2 clean-up. ``` but maybe we can? Especially if noone has plans to re-integrate. @jwren : do you have any context on this? --- - [x] I’ve reviewed the contributor guide and applied the relevant portions to this PR. <details> <summary>Contribution guidelines:</summary><br> - See our [contributor guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Dart contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Java and Kotlin contributions should strive to follow Java and Kotlin best practices ([discussion](#8098)). </details>
1 parent db039c0 commit 9bd3842

File tree

2 files changed

+1
-11
lines changed

2 files changed

+1
-11
lines changed

flutter-idea/src/io/flutter/module/settings/FlutterCreateAdditionalSettingsFields.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -142,10 +142,6 @@ public Insets getBorderInsets(Component c, Insets insets) {
142142
});
143143
}
144144

145-
public void updateProjectType(FlutterProjectType projectType) {
146-
// TODO(messick) Remove this method and its caller, which is in the flutter-studio module.
147-
}
148-
149145
public FlutterCreateAdditionalSettings getAdditionalSettings() {
150146
return new FlutterCreateAdditionalSettings.Builder()
151147
.setDescription(!descriptionField.getText().trim().isEmpty() ? descriptionField.getText().trim() : null)

flutter-studio/src/io/flutter/project/FlutterModuleGroup.java

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,17 +26,15 @@ public String getBuilderId() {
2626
public ModuleWizardStep getCustomOptionsStep(final WizardContext context, final Disposable parentDisposable) {
2727
// This runs each time the project type selection changes.
2828
FlutterModuleWizardStep step = (FlutterModuleWizardStep)super.getCustomOptionsStep(context, parentDisposable);
29-
assert step!= null;
29+
assert step != null;
3030
getSettingsField().linkHelpForm(step.getHelpForm());
31-
setProjectTypeInSettings();
3231
return step;
3332
}
3433

3534
@Override
3635
public ModuleWizardStep modifySettingsStep(@NotNull SettingsStep settingsStep) {
3736
// This runs when the Next button takes the wizard to the second page.
3837
ModuleWizardStep wizard = super.modifySettingsStep(settingsStep);
39-
setProjectTypeInSettings(); // TODO (messick) Remove this if possible (needs testing).
4038
return wizard;
4139
}
4240

@@ -46,10 +44,6 @@ public String getParentGroup() {
4644
return "Flutter";
4745
}
4846

49-
protected void setProjectTypeInSettings() {
50-
getSettingsField().updateProjectType(getFlutterProjectType());
51-
}
52-
5347
public static class App extends FlutterModuleGroup {
5448

5549
@NotNull

0 commit comments

Comments
 (0)