Skip to content

Fix the verifier setup in gradle, and update to use the latest verifier jar version #8034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jwren opened this issue Apr 9, 2025 · 0 comments · Fixed by #8077
Closed

Fix the verifier setup in gradle, and update to use the latest verifier jar version #8034

jwren opened this issue Apr 9, 2025 · 0 comments · Fixed by #8077
Assignees
@jwren
Milestone
M85.3

Comments

@jwren
Copy link
Member

jwren commented Apr 9, 2025

The version needs to be updated for sure. https://github.com/JetBrains/intellij-plugin-verifier/releases/tag/1.384

I think that the issue that broke it is two fold: some of the refactoring for 2025.1 broke the ability for it to run for the Flutter IJ plugin.

Also, when I updated the version the last time around, the jar wasn't in the PR, glancing at the .gitignore file, I think this was the issue. #7871

cc @pq
@jwren jwren added this to the M85.1 milestone Apr 9, 2025
@jwren jwren self-assigned this Apr 9, 2025
jwren added a commit to jwren/flutter-intellij that referenced this issue Apr 9, 2025
@jwren
Change the verifier CLI version back to 1.379
c96c8ef 
I thought this was working in January, however clearly the jar was not included in the original PR: flutter#7871

Changing back for now until we update the verifier jar again.

This is the start of the work involved with flutter#8034
@jwren jwren mentioned this issue Apr 9, 2025
Merged
jwren added a commit that referenced this issue Apr 10, 2025
@jwren
Change the verifier CLI version back to 1.379 (#8035)
334b829 
I thought this was working in January, however clearly the jar was not
included in the original PR:
#7871

Changing back for now until we update the verifier jar again.

This is the start of the work involved with
#8034
@jwren jwren mentioned this issue Apr 11, 2025
Open
@jwren jwren modified the milestones: M85.1, M85.2, M85.3 Apr 15, 2025
jwren added a commit to jwren/flutter-intellij that referenced this issue Apr 17, 2025
@jwren
Update the verifier to 1.384 and make changes in the build.gradle.kts…
18607e3 
… to fix the IJ Verifier for the Flutter plugin

This resolves flutter#8034
@jwren jwren mentioned this issue Apr 17, 2025
Merged
jwren added a commit to jwren/flutter-intellij that referenced this issue Apr 17, 2025
@jwren
Enable the verifier on the presubmits
d0bb9e9 
This is follow up on flutter#8034
@jwren jwren closed this as completed in 3768608 Apr 17, 2025
jwren added a commit to jwren/flutter-intellij that referenced this issue Apr 17, 2025
@jwren
Enable the verifier on the presubmits
6035894 
This is follow up on flutter#8034
@jwren jwren mentioned this issue Apr 17, 2025
Open
jwren added a commit to jwren/flutter-intellij that referenced this issue Apr 17, 2025
@jwren
Enable the verifier on the presubmits
e841815 
This is follow up on flutter#8034
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwren jwren

Labels
None yet
Projects
None yet
Milestone
M85.3
1 participant
@jwren