[plugins] Disables the AndroidGradlePluginVersion issue ID in all android packages (#7045)

FXschwartz · stuartmorgan-g · web-flow · commit 1acaf55c2d1f · 2023-02-19T22:08:22.000Z
* Disables the AndroidGradlePluginVersion issue ID in all android packages.

* Reverted changelog changes

* Reverted all changelog changes.

* Fixes changelog conflicts across android packages.

---------

Co-authored-by: Stuart Morgan &lt;stuartmorgan@google.com&gt;
diff --git a/packages/camera/camera_android/android/build.gradle b/packages/camera/camera_android/android/build.gradle
@@ -35,10 +35,7 @@ android {
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
     }
     lintOptions {
-        // TODO(stuartmorgan): Enable when gradle is updated.
-        // disable 'AndroidGradlePluginVersion'
-        disable 'InvalidPackage'
-        disable 'GradleDependency'
+        disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency'
         baseline file("lint-baseline.xml")
     }
     compileOptions {
diff --git a/packages/espresso/android/build.gradle b/packages/espresso/android/build.gradle
@@ -29,10 +29,7 @@ android {
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
     }
     lintOptions {
-        // TODO(stuartmorgan): Enable when gradle is updated.
-        // disable 'AndroidGradlePluginVersion'
-        disable 'InvalidPackage'
-        disable 'GradleDependency'
+        disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency'
         baseline file("lint-baseline.xml")
     }
 
diff --git a/packages/flutter_plugin_android_lifecycle/android/build.gradle b/packages/flutter_plugin_android_lifecycle/android/build.gradle
@@ -30,10 +30,7 @@ android {
         consumerProguardFiles 'proguard.txt'
     }
     lintOptions {
-        // TODO(stuartmorgan): Enable when gradle is updated.
-        // disable 'AndroidGradlePluginVersion'
-        disable 'InvalidPackage'
-        disable 'GradleDependency'
+        disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency'
     }
 
     dependencies {
diff --git a/packages/google_maps_flutter/google_maps_flutter_android/android/build.gradle b/packages/google_maps_flutter/google_maps_flutter_android/android/build.gradle
@@ -29,10 +29,7 @@ android {
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
     }
     lintOptions {
-        // TODO(stuartmorgan): Enable when gradle is updated.
-        // disable 'AndroidGradlePluginVersion'
-        disable 'InvalidPackage'
-        disable 'GradleDependency'
+        disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency'
     }
 
     dependencies {
diff --git a/packages/google_sign_in/google_sign_in_android/android/build.gradle b/packages/google_sign_in/google_sign_in_android/android/build.gradle
@@ -29,10 +29,7 @@ android {
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
     }
     lintOptions {
-        // TODO(stuartmorgan): Enable when gradle is updated.
-        // disable 'AndroidGradlePluginVersion'
-        disable 'InvalidPackage'
-        disable 'GradleDependency'
+        disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency'
     }
 
 
diff --git a/packages/image_picker/image_picker_android/android/build.gradle b/packages/image_picker/image_picker_android/android/build.gradle
@@ -29,9 +29,7 @@ android {
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
     }
     lintOptions {
-        disable 'AndroidGradlePluginVersion'
-        disable 'InvalidPackage'
-        disable 'GradleDependency'
+        disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency'
     }
     dependencies {
         implementation 'androidx.core:core:1.8.0'
diff --git a/packages/in_app_purchase/in_app_purchase_android/android/build.gradle b/packages/in_app_purchase/in_app_purchase_android/android/build.gradle
@@ -29,10 +29,7 @@ android {
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
     }
     lintOptions {
-        // TODO(stuartmorgan): Enable when gradle is updated.
-        // disable 'AndroidGradlePluginVersion'
-        disable 'InvalidPackage'
-        disable 'GradleDependency'
+        disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency'
     }
     compileOptions {
         sourceCompatibility JavaVersion.VERSION_1_8
diff --git a/packages/local_auth/local_auth_android/android/build.gradle b/packages/local_auth/local_auth_android/android/build.gradle
@@ -29,10 +29,7 @@ android {
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
     }
     lintOptions {
-        // TODO(stuartmorgan): Enable when gradle is updated.
-        // disable 'AndroidGradlePluginVersion'
-        disable 'InvalidPackage'
-        disable 'GradleDependency'
+        disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency'
         baseline file("lint-baseline.xml")
     }
 
diff --git a/packages/path_provider/path_provider_android/android/build.gradle b/packages/path_provider/path_provider_android/android/build.gradle
@@ -29,10 +29,7 @@ android {
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
     }
     lintOptions {
-        // TODO(stuartmorgan): Enable when gradle is updated.
-        // disable 'AndroidGradlePluginVersion'
-        disable 'InvalidPackage'
-        disable 'GradleDependency'
+        disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency'
     }
     compileOptions {
         sourceCompatibility JavaVersion.VERSION_1_8
diff --git a/packages/quick_actions/quick_actions_android/android/build.gradle b/packages/quick_actions/quick_actions_android/android/build.gradle
@@ -29,10 +29,7 @@ android {
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
     }
     lintOptions {
-        // TODO(stuartmorgan): Enable when gradle is updated.
-        // disable 'AndroidGradlePluginVersion'
-        disable 'InvalidPackage'
-        disable 'GradleDependency'
+        disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency'
     }
 
     dependencies {
diff --git a/packages/shared_preferences/shared_preferences_android/android/build.gradle b/packages/shared_preferences/shared_preferences_android/android/build.gradle
@@ -37,9 +37,7 @@ android {
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
     }
     lintOptions {
-        disable 'AndroidGradlePluginVersion'
-        disable 'InvalidPackage'
-        disable 'GradleDependency'
+        disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency'
         baseline file("lint-baseline.xml")
     }
     dependencies {
diff --git a/packages/url_launcher/url_launcher_android/android/build.gradle b/packages/url_launcher/url_launcher_android/android/build.gradle
@@ -29,9 +29,7 @@ android {
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
     }
     lintOptions {
-        disable 'AndroidGradlePluginVersion'
-        disable 'InvalidPackage'
-        disable 'GradleDependency'
+        disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency'
     }
 
 
diff --git a/packages/video_player/video_player_android/android/build.gradle b/packages/video_player/video_player_android/android/build.gradle
@@ -34,9 +34,7 @@ android {
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
     }
     lintOptions {
-        disable 'AndroidGradlePluginVersion'
-        disable 'InvalidPackage'
-        disable 'GradleDependency'
+        disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency'
     }
     compileOptions {
         sourceCompatibility JavaVersion.VERSION_1_8
diff --git a/packages/webview_flutter/webview_flutter_android/android/build.gradle b/packages/webview_flutter/webview_flutter_android/android/build.gradle
@@ -30,9 +30,7 @@ android {
     }
 
     lintOptions {
-        disable 'AndroidGradlePluginVersion'
-        disable 'InvalidPackage'
-        disable 'GradleDependency'
+        disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency'
     }
 
     dependencies {

Original file line number	Diff line number	Diff line change
`@@ -35,10 +35,7 @@ android {`
`35`	`35`	`testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"`
`36`	`36`	`}`
`37`	`37`	`lintOptions {`
`38`		`- // TODO(stuartmorgan): Enable when gradle is updated.`
`39`		`- // disable 'AndroidGradlePluginVersion'`
`40`		`- disable 'InvalidPackage'`
`41`		`- disable 'GradleDependency'`
	`38`	`+ disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency'`
`42`	`39`	`baseline file("lint-baseline.xml")`
`43`	`40`	`}`
`44`	`41`	`compileOptions {`
Original file line number	Diff line number	Diff line change
`@@ -29,10 +29,7 @@ android {`
`29`	`29`	`testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"`
`30`	`30`	`}`
`31`	`31`	`lintOptions {`
`32`		`- // TODO(stuartmorgan): Enable when gradle is updated.`
`33`		`- // disable 'AndroidGradlePluginVersion'`
`34`		`- disable 'InvalidPackage'`
`35`		`- disable 'GradleDependency'`
	`32`	`+ disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency'`
`36`	`33`	`baseline file("lint-baseline.xml")`
`37`	`34`	`}`
`38`	`35`
Original file line number	Diff line number	Diff line change
`@@ -30,10 +30,7 @@ android {`
`30`	`30`	`consumerProguardFiles 'proguard.txt'`
`31`	`31`	`}`
`32`	`32`	`lintOptions {`
`33`		`- // TODO(stuartmorgan): Enable when gradle is updated.`
`34`		`- // disable 'AndroidGradlePluginVersion'`
`35`		`- disable 'InvalidPackage'`
`36`		`- disable 'GradleDependency'`
	`33`	`+ disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency'`
`37`	`34`	`}`
`38`	`35`
`39`	`36`	`dependencies {`
Original file line number	Diff line number	Diff line change
`@@ -29,9 +29,7 @@ android {`
`29`	`29`	`testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"`
`30`	`30`	`}`
`31`	`31`	`lintOptions {`
`32`		`- disable 'AndroidGradlePluginVersion'`
`33`		`- disable 'InvalidPackage'`
`34`		`- disable 'GradleDependency'`
	`32`	`+ disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency'`
`35`	`33`	`}`
`36`	`34`	`dependencies {`
`37`	`35`	`implementation 'androidx.core:core:1.8.0'`
Original file line number	Diff line number	Diff line change
`@@ -37,9 +37,7 @@ android {`
`37`	`37`	`testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"`
`38`	`38`	`}`
`39`	`39`	`lintOptions {`
`40`		`- disable 'AndroidGradlePluginVersion'`
`41`		`- disable 'InvalidPackage'`
`42`		`- disable 'GradleDependency'`
	`40`	`+ disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency'`
`43`	`41`	`baseline file("lint-baseline.xml")`
`44`	`42`	`}`
`45`	`43`	`dependencies {`
Original file line number	Diff line number	Diff line change
`@@ -34,9 +34,7 @@ android {`
`34`	`34`	`testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"`
`35`	`35`	`}`
`36`	`36`	`lintOptions {`
`37`		`- disable 'AndroidGradlePluginVersion'`
`38`		`- disable 'InvalidPackage'`
`39`		`- disable 'GradleDependency'`
	`37`	`+ disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency'`
`40`	`38`	`}`
`41`	`39`	`compileOptions {`
`42`	`40`	`sourceCompatibility JavaVersion.VERSION_1_8`
Original file line number	Diff line number	Diff line change
`@@ -30,9 +30,7 @@ android {`
`30`	`30`	`}`
`31`	`31`
`32`	`32`	`lintOptions {`
`33`		`- disable 'AndroidGradlePluginVersion'`
`34`		`- disable 'InvalidPackage'`
`35`		`- disable 'GradleDependency'`
	`33`	`+ disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency'`
`36`	`34`	`}`
`37`	`35`
`38`	`36`	`dependencies {`