clippy (#1272)

Author: nilehmann

crates/flux-bin/build.rs

@@ -7,7 +7,7 @@ fn parse_output(output: Output) -> Option<String> {
 fn git_sha() -> Option<String> {
     parse_output(
         Command::new("git")
-            .args(&["describe", "--always", "--dirty=*"])
+            .args(["describe", "--always", "--dirty=*"])
             .output()
             .ok()?,
     )
@@ -16,7 +16,7 @@ fn git_sha() -> Option<String> {
 fn git_date() -> Option<String> {
     parse_output(
         Command::new("git")
-            .args(&["show", "-s", "--format=%cd", "--date=format:%Y-%m-%d", "HEAD"])
+            .args(["show", "-s", "--format=%cd", "--date=format:%Y-%m-%d", "HEAD"])
             .output()
             .ok()?,
     )

crates/flux-bin/src/bin/cargo-flux.rs

@@ -199,7 +199,7 @@ fn serde_json_to_config(
                 return Err(config::ConfigError::Message("invalid number".to_string()));
             }
         }
-        serde_json::Value::String(s) => config::ValueKind::String(s.to_string()),
+        serde_json::Value::String(s) => config::ValueKind::String(s.clone()),
         serde_json::Value::Array(values) => {
             config::ValueKind::Array(
                 values
@@ -211,7 +211,7 @@ fn serde_json_to_config(
         serde_json::Value::Object(map) => {
             config::ValueKind::Table(
                 map.iter()
-                    .map(|(k, v)| Ok((k.to_string(), serde_json_to_config(v, origin)?)))
+                    .map(|(k, v)| Ok((k.clone(), serde_json_to_config(v, origin)?)))
                     .try_collect()?,
             )
         }

crates/flux-desugar/src/desugar.rs

@@ -660,7 +660,7 @@ impl<'a, 'genv, 'tcx: 'genv> RustItemCtxt<'a, 'genv, 'tcx> {
                     span: loc.span,
                 };
                 let ty = self.desugar_ty(ty);
-                Ok(fhir::Ensures::Type(path, ty))
+                Ok(fhir::Ensures::Type(path, self.genv().alloc(ty)))
             }
             surface::Ensures::Pred(e) => {
                 let pred = self.desugar_expr(e);

crates/flux-middle/src/fhir.rs

@@ -509,7 +509,7 @@ pub struct FnOutput<'fhir> {
 #[derive(Clone, Copy)]
 pub enum Ensures<'fhir> {
     /// A type constraint on a location
-    Type(PathExpr<'fhir>, Ty<'fhir>),
+    Type(PathExpr<'fhir>, &'fhir Ty<'fhir>),
     /// A predicate that needs to hold on function exit
     Pred(Expr<'fhir>),
 }

crates/flux-refineck/src/ghost_statements.rs

@@ -143,7 +143,7 @@ impl GhostStatements {
         use rustc_middle::mir::{PassWhere, pretty::MirDumper};
         if let Some(dumper) = MirDumper::new(tcx, "ghost", body.inner()) {
             dumper
-                .set_extra_data(&mut |pass, w| {
+                .set_extra_data(&|pass, w| {
                     match pass {
                         PassWhere::BeforeBlock(bb) if bb == START_BLOCK => {
                             for stmt in &self.at_start {