Remove init methods, simplify const usage, simplify check function, return early based on named_arg_index

Author: dinomight

include/fmt/base.h

@@ -1060,20 +1060,18 @@ template <typename... Args> constexpr auto count_static_named_args() -> int {
 }
 
 template <typename Char> struct named_arg_info {
-  FMT_CONSTEXPR named_arg_info() : name(nullptr), id(0) {}
-  FMT_CONSTEXPR named_arg_info(const Char* a_name, const int an_id)
-      : name(a_name), id(an_id) {}
   const Char* name;
   int id;
 };
 
 template <typename Char>
 FMT_CONSTEXPR void check_for_duplicate(
-    const named_arg_info<Char>* const named_args, const int named_arg_index,
-    const Char* const arg_name) {
-  const basic_string_view<Char> arg_name_view(arg_name);
+    named_arg_info<Char>* named_args, int named_arg_index,
+    basic_string_view<Char> arg_name) {
+  if (named_arg_index <= 0) return;
+
   for (auto i = 0; i < named_arg_index; ++i) {
-    if (basic_string_view<Char>(named_args[i].name) == arg_name_view) {
+    if (basic_string_view<Char>(named_args[i].name) == arg_name) {
       report_error("duplicate named args found");
     }
   }
@@ -1087,7 +1085,7 @@ void init_named_arg(named_arg_info<Char>*, int& arg_index, int&, const T&) {
 template <typename Char, typename T, FMT_ENABLE_IF(is_named_arg<T>::value)>
 void init_named_arg(named_arg_info<Char>* named_args, int& arg_index,
                     int& named_arg_index, const T& arg) {
-  check_for_duplicate(named_args, named_arg_index, arg.name);
+  check_for_duplicate<Char>(named_args, named_arg_index, arg.name);
   named_args[named_arg_index++] = {arg.name, arg_index++};
 }
 
@@ -1101,7 +1099,7 @@ template <typename T, typename Char,
           FMT_ENABLE_IF(is_static_named_arg<T>::value)>
 FMT_CONSTEXPR void init_static_named_arg(named_arg_info<Char>* named_args,
                                          int& arg_index, int& named_arg_index) {
-  check_for_duplicate(named_args, named_arg_index, T::name);
+  check_for_duplicate<Char>(named_args, named_arg_index, T::name);
   named_args[named_arg_index++] = {T::name, arg_index++};
 }