Remove redundant JSON decode calls in model classes

Author: DigitallyBorn

lib/fog/aliyun/models/compute/eip_address.rb

@@ -33,7 +33,7 @@ def save(options = {})
           options[:bandwidth] = bandwidth if bandwidth
           options[:internet_charge_type] = charge_type if charge_type
 
-          data = Fog::JSON.decode(service.allocate_eip_address(options).body)
+          data = service.allocate_eip_address(options).body
           merge_attributes(data)
           true
         end

lib/fog/aliyun/models/compute/eip_addresses.rb

@@ -10,7 +10,7 @@ class EipAddresses < Fog::Collection
         model Fog::Compute::Aliyun::EipAddress
 
         def all(filters_arg = {})
-          data = Fog::JSON.decode(service.list_eip_addresses(filters_arg).body)['EipAddresses']['EipAddress']
+          data = service.list_eip_addresses(filters_arg).body['EipAddresses']['EipAddress']
           load(data)
           # load(data['volumeSet'])
           # if server

lib/fog/aliyun/models/compute/image.rb

@@ -39,7 +39,7 @@ def save(options = {})
           requires :snapshot_id
           options[:name] = name if name
           options[:description] = description if description
-          data = Fog::JSON.decode(service.create_image(snapshot_id, options).body)
+          data = service.create_image(snapshot_id, options).body
           merge_attributes(data)
           true
         end

lib/fog/aliyun/models/compute/images.rb

@@ -14,7 +14,7 @@ def all(filters_arg = {})
             Fog::Logger.deprecation("all with #{filters_arg.class} param is deprecated, use all('diskIds' => []) instead [light_black](#{caller.first})[/]")
             filters_arg = { imageId: filters_arg }
           end
-          data = Fog::JSON.decode(service.list_images(filters_arg).body)['Images']['Image']
+          data = service.list_images(filters_arg).body['Images']['Image']
           load(data)
         end
 

lib/fog/aliyun/models/compute/route_entrys.rb

@@ -14,7 +14,7 @@ class RouteEntrys < Fog::Collection
         def all(options = {})
           requires :route_table
           options[:routeTableId] = route_table.id
-          data = Fog::JSON.decode(service.list_route_tables(route_table.v_router_id, options).body)['RouteTables']['RouteTable'][0]['RouteEntrys']['RouteEntry']
+          data = service.list_route_tables(route_table.v_router_id, options).body['RouteTables']['RouteTable'][0]['RouteEntrys']['RouteEntry']
           load(data)
         end
 

lib/fog/aliyun/models/compute/route_tables.rb

@@ -13,7 +13,7 @@ class RouteTables < Fog::Collection
 
         def all(options = {})
           requires :v_router
-          data = Fog::JSON.decode(service.list_route_tables(v_router.id, options).body)['RouteTables']['RouteTable']
+          data = service.list_route_tables(v_router.id, options).body['RouteTables']['RouteTable']
           load(data)
         end
 

lib/fog/aliyun/models/compute/security_group.rb

@@ -26,7 +26,7 @@ def save(options = {})
           options[:vpcId] = vpc_id if vpc_id
           options[:name] = name if name
           options[:description] = description if description
-          Fog::JSON.decode(service.create_security_group(options).body)
+          service.create_security_group(options).body
           true
         end
 

lib/fog/aliyun/models/compute/security_group_rules.rb

@@ -11,7 +11,7 @@ class SecurityGroupRules < Fog::Collection
         attribute :security_group_id
 
         def get(security_group_id, options = {})
-          data = Fog::JSON.decode(service.list_security_group_rules(security_group_id, options).body)
+          data = service.list_security_group_rules(security_group_id, options).body
           self.security_group_id = data['SecurityGroupId']
           permissions = data['Permissions']['Permission']
           permissions.each do |permission|

lib/fog/aliyun/models/compute/security_groups.rb

@@ -10,7 +10,7 @@ class SecurityGroups < Fog::Collection
         model Fog::Compute::Aliyun::SecurityGroup
 
         def all(options = {})
-          data = Fog::JSON.decode(service.list_security_groups(options).body)['SecurityGroups']['SecurityGroup']
+          data = service.list_security_groups(options).body['SecurityGroups']['SecurityGroup']
           load(data)
           # ['Images']['Image']
         end

lib/fog/aliyun/models/compute/snapshot.rb

@@ -33,7 +33,7 @@ def save(options = {})
           requires :volume_id
           options[:name] = name if name
           options[:description] = description if description
-          data = Fog::JSON.decode(service.create_snapshot(volume_id, options).body)
+          data = service.create_snapshot(volume_id, options).body
           merge_attributes(data)
           true
         end