Fix: Customized field label not loaded (#291)

Author: hongquan

src/pretalx/cfp/forms/cfp.py

@@ -1,3 +1,8 @@
+import logging
+
+logger = logging.getLogger(__name__)
+
+
 class CfPFormMixin:
     """All forms used in the CfP step process should use this mixin.
 

src/pretalx/cfp/views/user.py

@@ -63,14 +63,19 @@ def token(self):
     @cached_property
     def profile_form(self):
         bind = is_form_bound(self.request, "profile")
+        cfp_flow_config = self.request.event.cfp_flow.config
+        try:
+            # TODO: There may be a mismatch somewhere else between how the config was saved and how it is loaded.
+            # We should use Pydantic model for saving and loading, to make sure the data is consistent.
+            field_configuration = cfp_flow_config["steps"]["profile"]["fields"]
+        except KeyError:
+            field_configuration = None
         return SpeakerProfileForm(
             user=self.request.user,
             event=self.request.event,
             read_only=False,
             with_email=False,
-            field_configuration=self.request.event.cfp_flow.config.get(
-                "profile", {}
-            ).get("fields"),
+            field_configuration=field_configuration,
             data=self.request.POST if bind else None,
             files=self.request.FILES if bind else None,
         )

src/pretalx/common/templates/common/avatar.html

@@ -27,13 +27,13 @@
     </div>
 </div>
 <div class="avatar-form form-group row">
-    <label class="col-md-3 col-form-label">{{ _('Profile picture source') }}</label>
+    <label class="col-md-3 col-form-label">{{ form.avatar_source.field.label }}</label>
     <div class="col-md-9">
         {{ form.avatar_source.as_widget }}
     </div>
 </div>
 <div class="avatar-form form-group row">
-    <label class="col-md-3 col-form-label">{{ _('Profile picture license') }}</label>
+    <label class="col-md-3 col-form-label">{{ form.avatar_license.field.label }}</label>
     <div class="col-md-9">
         {{ form.avatar_license.as_widget }}
     </div>

src/pretalx/orga/views/cfp.py

@@ -816,5 +816,6 @@ def post(self, request, *args, **kwargs):
         if "action" in data and data["action"] == "reset":
             flow.reset()
         else:
+            logger.debug("Saving new CfP flow configuration: %s", data)
             flow.save_config(data)
         return JsonResponse({"success": True})