Skip to content

chore: enable more clippy lint #10149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Tracked by #10425
taikoonwang opened this issue Mar 21, 2025 · 1 comment
Open
Tracked by #10425

chore: enable more clippy lint #10149

taikoonwang opened this issue Mar 21, 2025 · 1 comment
Labels
A-internals Area: internals T-chore Type: chore

Comments

@taikoonwang
Copy link
Contributor

taikoonwang commented Mar 21, 2025 •
edited
Loading

Component

Other (please describe)

Describe the feature you would like

checked reth's workspace.lints.clippy, enable more linters to maintain code style consistency.

A small question: should I do it in a sepeate PR for lint (for easier review) or do it within a larger PR for whole linters? @grandizzy

Additional context

No response
@taikoonwang taikoonwang added T-feature Type: feature T-needs-triage Type: this issue needs to be labelled labels Mar 21, 2025
@github-project-automation github-project-automation bot moved this to Todo in Foundry Mar 21, 2025
@taikoonwang taikoonwang mentioned this issue Mar 21, 2025
Closed
3 tasks
@grandizzy
Copy link
Collaborator

@taikoonwang singoe PR should work, thank you! Cc @DaniPopes @zerosnacks re new lints

@zerosnacks zerosnacks changed the title enable more clippy lint chore: enable more clippy lint Mar 24, 2025
@zerosnacks zerosnacks added A-internals Area: internals T-chore Type: chore and removed T-feature Type: feature T-needs-triage Type: this issue needs to be labelled labels Mar 24, 2025
@jenpaff jenpaff moved this from Todo to Ready For Review in Foundry Apr 15, 2025
@0xrusowsky 0xrusowsky mentioned this issue May 2, 2025
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-internals Area: internals T-chore Type: chore
Projects
Foundry
Status: Ready For Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: enable more clippy lint taikoonwang/foundry
3 participants
@grandizzy @zerosnacks @taikoonwang