Skip to content

feat(cast mktx --raw-unsigned): add way to accept signatures to build a transaction #10167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
AdvayAgrawal opened this issue Mar 24, 2025 · 8 comments · May be fixed by #10377
Open

feat(cast mktx --raw-unsigned): add way to accept signatures to build a transaction #10167

AdvayAgrawal opened this issue Mar 24, 2025 · 8 comments · May be fixed by #10377
Labels
C-cast Command: cast first issue A good way to start contributing T-feature Type: feature

Comments

@AdvayAgrawal
Copy link

Component

Cast

Describe the feature you would like

for reference, this is what i wish to achieve using foundry tools
https://medium.com/@LucasJennings/a-step-by-step-guide-to-generating-raw-ethereum-transactions-c3292ad36ab4

Thanks to the newly introduced --raw-unsigned flag, I am able to create a raw RLP transaction, hash it and sign it using cast wallet sign

what is left is to be able to use the signature to create a new RLP transaction, which now includes the created signature using cast mktx to create a raw ethereum transaction

As per the medium article reference, Step 4 is to be tackled.

Hope this was enough information, let me know if this is feasable
Thanks

Additional context

No response
@AdvayAgrawal AdvayAgrawal added T-feature Type: feature T-needs-triage Type: this issue needs to be labelled labels Mar 24, 2025
@github-project-automation github-project-automation bot moved this to Todo in Foundry Mar 24, 2025
@AdvayAgrawal
Copy link
Author

hi @zerosnacks. Is this feature feasible?

@grandizzy grandizzy added first issue A good way to start contributing C-cast Command: cast and removed T-needs-triage Type: this issue needs to be labelled labels Mar 25, 2025
@zerosnacks
Copy link
Member

Yes it is, we've marked it as a good first issue

cc @yash-atreya

@zerosnacks zerosnacks changed the title Feature request: Add field in cast mktx --raw-unsigned to accept signatures to build an ethereum transaction feat(cast mktx --raw-unsigned): add way to accept signatures to build an ethereum transaction Mar 25, 2025
@zerosnacks zerosnacks changed the title feat(cast mktx --raw-unsigned): add way to accept signatures to build an ethereum transaction feat(cast mktx --raw-unsigned): add way to accept signatures to build a transaction Mar 25, 2025
@AdvayAgrawal
Copy link
Author

great, glad to hear that. Thanks @zerosnacks

@A-y-ush
Copy link

A-y-ush commented Mar 26, 2025

Hi, @zerosnacks is this issue available to work on?
I wanna know if I understand the problem correctly
When we create an unsigned transaction using the cast mktx command without the --raw-unsigned flag, the transaction is EIP-2718 encoded. During this time, it gets both signed and encoded.
But in the case of using the --raw-unsigned flag, the transaction misses the step of RLP encoding too along with the signing part.
Am I understanding this correct?

@AdvayAgrawal
Copy link
Author

hi @zerosnacks @yash-atreya ,

Just wanted to know an update on this, has this issue been resolved, or is there a linked PR?

@yash-atreya
Copy link
Member

hi @zerosnacks @yash-atreya ,

Just wanted to know an update on this, has this issue been resolved, or is there a linked PR?

Hey, would you like to submit a PR for this?

@AdvayAgrawal
Copy link
Author

@yash-atreya I haven't worked on it yet, but i'd be open to do so

If no one has taken it up yet, i'll come up with a PR

This was referenced Apr 26, 2025
Closed
Open
@Ayushdubey86
Copy link
Contributor

Hi @yash-atreya @zerosnacks @AdvayAgrawal raised a pr for this , do check it out! #10377

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cast Command: cast first issue A good way to start contributing T-feature Type: feature
Projects
Foundry
Status: Todo
Milestone
No milestone
6 participants
@grandizzy @yash-atreya @Ayushdubey86 @AdvayAgrawal @zerosnacks @A-y-ush