Always use data transformer unless --calldata is passed (#3314)

<!-- Reference any GitHub issues resolved by this PR -->

Closes #2760

## Introduced changes

<!-- A brief description of the changes -->

- Always use data transformer unless --calldata is passed

## Checklist

<!-- Make sure all of these are complete -->

- [x] Linked relevant issue
- [x] Updated relevant documentation
- [x] Added relevant tests
- [x] Performed self-review of the code
- [x] Added changes to `CHANGELOG.md`

Author: ksew1

crates/data-transformer/src/reverse_transformer/mod.rs

@@ -8,7 +8,7 @@ use starknet_types_core::felt::Felt;
 
 #[derive(Debug, thiserror::Error)]
 pub enum ReverseTransformError {
-    #[error(r#"Function with selector "{0}" not found in ABI of the contract"#)]
+    #[error(r#"Function with selector "{0:#x}" not found in ABI of the contract"#)]
     FunctionNotFound(Felt),
     #[error(transparent)]
     TransformationError(#[from] TransformationError),

crates/data-transformer/src/shared/extraction.rs

@@ -6,6 +6,27 @@ pub fn extract_function_from_selector(
     abi: &[AbiEntry],
     searched_selector: Felt,
 ) -> Option<AbiFunction> {
+    const CONSTRUCTOR_AS_SELECTOR: Felt = Felt::from_hex_unchecked(
+        "0x28ffe4ff0f226a9107253e17a904099aa4f63a02a5621de0576e5aa71bc5194",
+    );
+
+    search_for_function(abi, searched_selector)
+        // If the user doesn't explicitly define a constructor in the contract,
+        // it won't be present in the ABI. In such cases, an implicit constructor
+        // with no arguments is assumed.
+        .or_else(|| (searched_selector == CONSTRUCTOR_AS_SELECTOR).then(default_constructor))
+}
+
+fn default_constructor() -> AbiFunction {
+    AbiFunction {
+        name: "constructor".to_string(),
+        inputs: vec![],
+        outputs: vec![],
+        state_mutability: StateMutability::View,
+    }
+}
+
+fn search_for_function(abi: &[AbiEntry], searched_selector: Felt) -> Option<AbiFunction> {
     abi.iter().find_map(|entry| match entry {
         AbiEntry::Function(func) => {
             let selector = get_selector_from_name(&func.name).ok()?;
@@ -23,9 +44,7 @@ pub fn extract_function_from_selector(
                 state_mutability: StateMutability::View,
             })
         }
-        AbiEntry::Interface(interface) => {
-            extract_function_from_selector(&interface.items, searched_selector)
-        }
+        AbiEntry::Interface(interface) => search_for_function(&interface.items, searched_selector),
         _ => None,
     })
 }

crates/data-transformer/src/transformer/mod.rs

@@ -14,7 +14,9 @@ use starknet::core::types::contract::{AbiEntry, AbiFunction};
 /// Interpret `calldata` as a comma-separated series of expressions in Cairo syntax and serialize it
 pub fn transform(calldata: &str, abi: &[AbiEntry], function_selector: &Felt) -> Result<Vec<Felt>> {
     let function = extract_function_from_selector(abi, *function_selector).with_context(|| {
-        format!(r#"Function with selector "{function_selector}" not found in ABI of the contract"#)
+        format!(
+            r#"Function with selector "{function_selector:#x}" not found in ABI of the contract"#
+        )
     })?;
 
     let db = SimpleParserDatabase::default();
@@ -25,6 +27,9 @@ pub fn transform(calldata: &str, abi: &[AbiEntry], function_selector: &Felt) ->
 }
 
 fn split_expressions(input: &str, db: &SimpleParserDatabase) -> Result<Vec<Expr>> {
+    if input.is_empty() {
+        return Ok(Vec::new());
+    }
     // We need to convert our comma-separated string of expressions into something that is a valid
     // Cairo expression, so we can parse it.
     //

crates/data-transformer/tests/data/data_transformer/src/lib.cairo

@@ -62,6 +62,7 @@ pub trait IDataTransformer<TContractState> {
     ) -> (BitArray, alexandria_data_structures::bit_array::BitArray);
     fn span_fn(ref self: TContractState, a: Span<felt252>) -> Span<felt252>;
     fn multiple_signed_fn(ref self: TContractState, a: i32, b: i8);
+    fn no_args_fn(ref self: TContractState);
 }
 
 #[starknet::contract]
@@ -129,5 +130,12 @@ mod DataTransformer {
             a
         }
         fn multiple_signed_fn(ref self: ContractState, a: i32, b: i8) {}
+        fn no_args_fn(ref self: ContractState) {}
     }
 }
+
+#[starknet::contract]
+mod DataTransformerNoConstructor {
+    #[storage]
+    struct Storage {}
+}

crates/data-transformer/tests/integration/identity.rs

@@ -22,6 +22,7 @@ use test_case::test_case;
 #[test_case("Enum::Two(128_u128)", "enum_fn"; "enum_tuple")]
 #[test_case("Enum::Three(NestedStructWithField { a: SimpleStruct { a: 0x7b }, b: 0xea })", "enum_fn"; "enum_nested")]
 #[test_case(r#"ComplexStruct { a: NestedStructWithField { a: SimpleStruct { a: 0x1 }, b: 0x2 }, b: 0x3, c: 4_u8, d: 5_i32, e: Enum::Two(6_u128), f: "seven", g: array![0x8, 0x9], h: 10_u256, i: (11_i128, 12_u128) }"#, "complex_struct_fn"; "complex_struct")]
+#[test_case("", "no_args_fn"; "no_arguments_function")]
 #[tokio::test]
 async fn test_check_for_identity(calldata: &str, selector: &str) {
     let abi = get_abi().await;

crates/data-transformer/tests/integration/mod.rs

@@ -10,25 +10,29 @@ mod identity;
 mod reverse_transformer;
 mod transformer;
 
-// Class hash of the declared contract from /tests/data/data_transformer
+/// Class hash of the declared `DataTransformer` contract from `/tests/data/data_transformer`
 const TEST_CLASS_HASH: Felt =
-    Felt::from_hex_unchecked("0x02978c91b2c3d47cba2103d40280a3601b90ed93a59cebc2ad61c6d1dab5e10a");
+    Felt::from_hex_unchecked("0x071b56ab58087fd00a0b4ddcdfecb727ae11d1674a4a0f5af7c30f9bb2f7150e");
+
+/// Class hash of the declared `DataTransformerNoConstructor` contract from `/tests/data/data_transformer`
+const NO_CONSTRUCTOR_CLASS_HASH: Felt =
+    Felt::from_hex_unchecked("0x051d0347d3bfcd87eea5175994f55158a24b003370d8c83d2c430f663eceb08d");
 
 static CLASS: OnceCell<ContractClass> = OnceCell::const_new();
 
-async fn init_class() -> ContractClass {
+async fn init_class(class_hash: Felt) -> ContractClass {
     let client = JsonRpcClient::new(HttpTransport::new(
         Url::parse("http://188.34.188.184:7070/rpc/v0_8").unwrap(),
     ));
 
     client
-        .get_class(BlockId::Tag(BlockTag::Latest), TEST_CLASS_HASH)
+        .get_class(BlockId::Tag(BlockTag::Latest), class_hash)
         .await
         .unwrap()
 }
 
 async fn get_abi() -> Vec<AbiEntry> {
-    let class = CLASS.get_or_init(init_class).await;
+    let class = CLASS.get_or_init(|| init_class(TEST_CLASS_HASH)).await;
     let ContractClass::Sierra(sierra_class) = class else {
         panic!("Expected Sierra class, but got legacy Sierra class")
     };

crates/data-transformer/tests/integration/reverse_transformer.rs

@@ -1,7 +1,9 @@
-use crate::integration::get_abi;
+use crate::integration::{NO_CONSTRUCTOR_CLASS_HASH, get_abi, init_class};
 use data_transformer::{reverse_transform_input, reverse_transform_output};
 use itertools::Itertools;
 use primitive_types::U256;
+use starknet::core::types::ContractClass;
+use starknet::core::types::contract::AbiEntry;
 use starknet::core::utils::get_selector_from_name;
 use starknet_types_core::felt::Felt;
 
@@ -339,3 +341,26 @@ async fn test_multiple_signed_max() {
     )
     .await;
 }
+
+#[tokio::test]
+async fn test_no_argument_function() {
+    assert_reverse_transformation(&[], "no_args_fn", "", None).await;
+}
+
+#[tokio::test]
+async fn test_implicit_contract_constructor() {
+    let class = init_class(NO_CONSTRUCTOR_CLASS_HASH).await;
+    let ContractClass::Sierra(sierra_class) = class else {
+        panic!("Expected Sierra class, but got legacy Sierra class")
+    };
+
+    let abi: Vec<AbiEntry> = serde_json::from_str(sierra_class.abi.as_str()).unwrap();
+
+    let result =
+        reverse_transform_input(&[], &abi, &get_selector_from_name("constructor").unwrap())
+            .unwrap();
+
+    let expected_output = "";
+
+    assert_eq!(result, expected_output);
+}

crates/data-transformer/tests/integration/transformer.rs

@@ -1,4 +1,4 @@
-use crate::integration::get_abi;
+use crate::integration::{NO_CONSTRUCTOR_CLASS_HASH, get_abi, init_class};
 use core::fmt;
 use data_transformer::transform;
 use indoc::indoc;
@@ -43,7 +43,7 @@ async fn test_function_not_found() {
 
     result.unwrap_err().assert_contains(
         format!(
-            r#"Function with selector "{}" not found in ABI of the contract"#,
+            r#"Function with selector "{:#x}" not found in ABI of the contract"#,
             get_selector_from_name(selector).unwrap()
         )
         .as_str(),
@@ -540,6 +540,31 @@ async fn test_happy_case_contract_constructor() {
     assert_eq!(result, expected_output);
 }
 
+#[tokio::test]
+async fn test_happy_case_no_argument_function() {
+    let result = run_transformer("", "no_args_fn").await.unwrap();
+
+    let expected_output = [];
+
+    assert_eq!(result, expected_output);
+}
+
+#[tokio::test]
+async fn test_happy_case_implicit_contract_constructor() {
+    let class = init_class(NO_CONSTRUCTOR_CLASS_HASH).await;
+    let ContractClass::Sierra(sierra_class) = class else {
+        panic!("Expected Sierra class, but got legacy Sierra class")
+    };
+
+    let abi: Vec<AbiEntry> = serde_json::from_str(sierra_class.abi.as_str()).unwrap();
+
+    let result = transform("", &abi, &get_selector_from_name("constructor").unwrap()).unwrap();
+
+    let expected_output = [];
+
+    assert_eq!(result, expected_output);
+}
+
 #[tokio::test]
 async fn test_external_enum_function_ambiguous_enum_name_cairo_expression_input() {
     // https://sepolia.starkscan.co/class/0x019ea00ebe2d83fb210fbd6f52c302b83c69e3c8c934f9404c87861e9d3aebbc#code

crates/sncast/src/main.rs

@@ -175,16 +175,7 @@ impl Arguments {
         contract_class: ContractClass,
         selector: &Felt,
     ) -> Result<Vec<Felt>> {
-        if let Some(arguments) = self.arguments {
-            let ContractClass::Sierra(sierra_class) = contract_class else {
-                bail!("Transformation of arguments is not available for Cairo Zero contracts")
-            };
-
-            let abi: Vec<AbiEntry> = serde_json::from_str(sierra_class.abi.as_str())
-                .context("Couldn't deserialize ABI received from network")?;
-
-            transform(&arguments, &abi, selector)
-        } else if let Some(calldata) = self.calldata {
+        if let Some(calldata) = self.calldata {
             calldata
                 .iter()
                 .map(|data| {
@@ -194,7 +185,14 @@ impl Arguments {
                 })
                 .collect()
         } else {
-            Ok(vec![])
+            let ContractClass::Sierra(sierra_class) = contract_class else {
+                bail!("Transformation of arguments is not available for Cairo Zero contracts")
+            };
+
+            let abi: Vec<AbiEntry> = serde_json::from_str(sierra_class.abi.as_str())
+                .context("Couldn't deserialize ABI received from network")?;
+
+            transform(&self.arguments.unwrap_or_default(), &abi, selector)
         }
     }
 }

crates/sncast/tests/e2e/call.rs

@@ -141,14 +141,11 @@ fn test_wrong_function_name() {
     ];
 
     let snapbox = runner(&args);
-    let output = snapbox.assert().success();
+    let output = snapbox.assert().failure();
 
     assert_stderr_contains(
         output,
-        indoc! {r"
-        command: call
-        error: Requested entrypoint does not exist in the contract
-        "},
+        r#"Error: Function with selector "0x2924aec1f107eca35a5dc447cee68cc6985fe404841c9aad477adfcbe596d0a" not found in ABI of the contract"#,
     );
 }
 

crates/sncast/tests/e2e/invoke.rs

@@ -198,7 +198,6 @@ async fn test_contract_does_not_exist() {
     );
 }
 
-// TODO(#3116): Before, the error message included 'ENTRYPOINT_NOT_FOUND', but now it's an undecoded felt.
 #[test]
 fn test_wrong_function_name() {
     let args = vec![
@@ -216,14 +215,11 @@ fn test_wrong_function_name() {
     ];
 
     let snapbox = runner(&args);
-    let output = snapbox.assert().success();
+    let output = snapbox.assert().failure();
 
     assert_stderr_contains(
         output,
-        indoc! {"
-            command: invoke
-            error: Transaction execution error [..]0x454e545259504f494e545f4e4f545f464f554e44[..]
-        "},
+        r#"Error: Function with selector "0x2e0f845a8d0319c5c37d558023299beec2a0155d415f41cca140a09e6877c67" not found in ABI of the contract"#,
     );
 }