From 99b197372136fb87bc183cb4b9e11aee4c599e08 Mon Sep 17 00:00:00 2001 From: Shuu Date: Sun, 28 Jul 2024 09:08:12 +0900 Subject: [PATCH] Escaping newlines in Log viewer buffer (#2119) --- ...752_github-actions[bot]_newline-in-logviewer.rst | 7 +++++++ src/moepkg/logviewerutils.nim | 4 ++-- tests/tlogviewerutils.nim | 13 +++++++++++++ 3 files changed, 22 insertions(+), 2 deletions(-) create mode 100644 changelog.d/20240727_235752_github-actions[bot]_newline-in-logviewer.rst diff --git a/changelog.d/20240727_235752_github-actions[bot]_newline-in-logviewer.rst b/changelog.d/20240727_235752_github-actions[bot]_newline-in-logviewer.rst new file mode 100644 index 000000000..142fa7693 --- /dev/null +++ b/changelog.d/20240727_235752_github-actions[bot]_newline-in-logviewer.rst @@ -0,0 +1,7 @@ +.. _#2119: https://github.com/fox0430/moe/pull/2119 + +Fixed +..... + +- `#2119`_ Escaping newlines in Log viewer buffer + diff --git a/src/moepkg/logviewerutils.nim b/src/moepkg/logviewerutils.nim index 40205ef4b..d4c3b2b55 100644 --- a/src/moepkg/logviewerutils.nim +++ b/src/moepkg/logviewerutils.nim @@ -43,8 +43,8 @@ proc initEditorLogViewrBuffer*(): seq[Runes] = if log.len == 0: return @[ru""] - for i, l in log: - result.add l + for i, line in log: + for l in line.splitLines: result.add l if i < log.high: result.add ru"" diff --git a/tests/tlogviewerutils.nim b/tests/tlogviewerutils.nim index 6b0c38727..d12bc10e0 100644 --- a/tests/tlogviewerutils.nim +++ b/tests/tlogviewerutils.nim @@ -57,6 +57,19 @@ suite "logviewerutils: initEditorLogViewrBuffer": ] .toSeqRunes + test "With new line": + addMessageLog "line1.0\nline1.1" + addMessageLog "line2.0\nline2.1" + + check initEditorLogViewrBuffer() == @[ + "line1.0", + "line1.1", + "", + "line2.0", + "line2.1" + ] + .toSeqRunes + suite "logviewerutils: initLspLogViewrBuffer": setup: clearMessageLog()