Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

view image #22

Open
PepaBosnis opened this issue Aug 13, 2016 · 0 comments
Open

view image #22

PepaBosnis opened this issue Aug 13, 2016 · 0 comments

Comments

@PepaBosnis
Copy link

Great library, but I came for one thing. If you add an image in the form of "data: image / png ....." then you need minor adjustments in ImageLoader

if (image.src.indexOf('data:image/') === -1) {
image.src += "?" + new Date().getTime();
}

fperucic pushed a commit that referenced this issue Sep 28, 2016
* Allow for non-id containers

* Treant uses the drawArea as a native dom object and not a jQuery object, so using .get(0)

* Simplify use of addClass/removeClass to toggleClass

* Add a callback for onCollapseFinished

* A few minor comment spelling corrections

* Added onCreateNode and onCreateNodeCollapseSwitch. Further, using jQuery’s well established $.extend for deep merge of configuration objects which means we can now supply callback functions (without $.extend the local UTIL.createMerge doesn’t work for this functionality)

* Beginnings of having optional jQuery support

* Moved findEl to UTIL and moved the configuration of $ to Treant instead of Tree

* Added a UTIL.toggleClass to help remove the jQuery dependency

* Fix for jQuery usage of extend()

* Implemented the ability to have the drawArea autosize according to the tree content.

* Removed the last of the jQuery dependencies. This means the collapse/expand works without jQuery being available.

* Address issues #22; uses the suggestion given but ensures not to affect the load process (because it internally tracks the images being loaded). Relaxed the indexOf up to the colon as a URL will not include “data:”, but may not be followed by “image/“.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant