Add update op to network monitor (#1578)

Co-authored-by: Alexis Batyk <[email protected]>
Co-authored-by: nacho.d.g <[email protected]>
Co-authored-by: Ian Clarke (aider) <[email protected]>

Author: 4 people

Cargo.lock

@@ -68,7 +68,7 @@ impl<const N: usize> super::ClientEventsProxy for ClientEventsCombinator<N> {
     fn recv(&mut self) -> BoxFuture<'_, Result<OpenRequest<'static>, ClientError>> {
         async {
             let Some((idx, mut rx, res)) = self.pending_futs.next().await else {
-                unreachable!();
+                unreachable!("pending_futs should always have a future unless the combinator is dropped");
             };
 
             let res = res

crates/core/src/client_events/combinator.rs

@@ -233,7 +233,7 @@ where
             }
             res = results.next(), if !results.is_empty() => {
                 let Some(f_res) = res else {
-                    unreachable!();
+                    unreachable!("results.next() should only return None if results is empty, which is guarded against");
                 };
                 match f_res {
                     (cli_id, Ok(Some(res))) => {
@@ -592,14 +592,14 @@ async fn process_open_request(
                 })));
             }
             ClientRequest::Disconnect { .. } => {
-                unreachable!();
+                tracing::debug!("Received disconnect from user event");
             }
             ClientRequest::NodeQueries(_) => {
                 tracing::debug!("Received node queries from user event");
 
                 let Some(tx) = callback_tx else {
                     tracing::error!("callback_tx not available for NodeQueries");
-                    unreachable!();
+                    unreachable!("callback_tx should always be Some for NodeQueries based on initialization logic");
                 };
 
                 if let Err(err) = op_manager
@@ -1041,7 +1041,9 @@ pub(crate) mod test {
                         };
                         return Some(request.into());
                     }
-                    _ => unreachable!(),
+                    _ => unreachable!(
+                        "gen_range(0..100) should always fall into one of the defined ranges"
+                    ),
                 }
             }
             None

crates/core/src/client_events/mod.rs

@@ -407,7 +407,7 @@ async fn new_client_connection(
     match response_recv.recv().await {
         Some(HostCallbackResult::NewId { id: client_id, .. }) => Ok((response_recv, client_id)),
         None => Err(ErrorKind::NodeUnavailable.into()),
-        other => unreachable!("received unexpected message: {other:?}"),
+        other => unreachable!("received unexpected message after NewConnection: {other:?}"),
     }
 }
 

crates/core/src/client_events/websocket.rs

@@ -669,7 +669,7 @@ impl ConfigPathsArgs {
             .unwrap_or_else(|| {
                 let default_dirs = Self::default_dirs(id)?;
                 let Either::Left(defaults) = default_dirs else {
-                    unreachable!()
+                    unreachable!("default_dirs should return Left if data_dir is None and id is not set for temp dir")
                 };
                 Ok(defaults.data_dir().to_path_buf())
             })?;
@@ -712,7 +712,7 @@ impl ConfigPathsArgs {
             .unwrap_or_else(|| {
                 let default_dirs = Self::default_dirs(id)?;
                 let Either::Left(defaults) = default_dirs else {
-                    unreachable!()
+                    unreachable!("default_dirs should return Left if config_dir is None and id is not set for temp dir")
                 };
                 Ok(defaults.config_dir().to_path_buf())
             })?;
@@ -968,7 +968,7 @@ impl GlobalExecutor {
         } else if let Some(rt) = &*ASYNC_RT {
             rt.spawn(f)
         } else {
-            unreachable!("the executor must have been initialized")
+            unreachable!("ASYNC_RT should be initialized if Handle::try_current fails")
         }
     }
 }

crates/core/src/config/mod.rs

@@ -41,7 +41,7 @@ impl Executor<MockRuntime> {
         _req: ClientRequest<'_>,
         _updates: Option<mpsc::UnboundedSender<Result<HostResponse, WsClientError>>>,
     ) -> Response {
-        unreachable!()
+        unreachable!("MockRuntime does not handle client requests directly")
     }
 }
 
@@ -105,7 +105,7 @@ impl ContractExecutor for Executor<MockRuntime> {
                     .map_err(ExecutorError::other)?;
                 Ok(UpsertResult::Updated(incoming_state))
             }
-            (update, contract) => unreachable!("{update:?}, {contract:?}"),
+            (update, contract) => unreachable!("Invalid combination of state/delta and contract presence: {update:?}, {contract:?}"),
         }
     }
 

crates/core/src/contract/executor/mock_runtime.rs

@@ -113,7 +113,7 @@ where
                         ContractHandlerEvent::PutResponse {
                             new_value: Err(err),
                         }
-                    }
+                    } // UpsertResult::NotAvailable is not used in this path
                 };
 
                 contract_handler
@@ -228,7 +228,7 @@ where
                         tracing::debug!(%error, "shutting down contract handler");
                     })?;
             }
-            _ => unreachable!(),
+            _ => unreachable!("ContractHandlerEvent enum should be exhaustive here"),
         }
     }
 }