-
Notifications
You must be signed in to change notification settings - Fork 6
Open
Labels
part:actorAffects the dispatching actorAffects the dispatching actorscope:breaking-changeBreaking change, users will need to update their codeBreaking change, users will need to update their codetype:enhancementNew feature or enhancement visitble to usersNew feature or enhancement visitble to users
Description
What's needed?
We need to be consistent between the Dispatch
and DispatchInfo
classes. Dispatch
uses target
for the target components, and it makes sense, because it can also be categories. DispatchInfo
should use the same.
Proposed solution
Rename DispatchInfo.components
to DispatchInfo.target
.
Additional context
frequenz-dispatch-python/src/frequenz/dispatch/_actor_dispatcher.py
Lines 23 to 33 in ecaca06
class DispatchInfo: | |
"""Event emitted when the dispatch changes.""" | |
components: TargetComponents | |
"""Components to be used.""" | |
dry_run: bool | |
"""Whether this is a dry run.""" | |
options: dict[str, Any] | |
"""Additional options.""" |
Metadata
Metadata
Assignees
Labels
part:actorAffects the dispatching actorAffects the dispatching actorscope:breaking-changeBreaking change, users will need to update their codeBreaking change, users will need to update their codetype:enhancementNew feature or enhancement visitble to usersNew feature or enhancement visitble to users