Skip to content

Replace operator == for floating-point comparison in test #965

Open
@daniel-zullo-frequenz

Description

@daniel-zullo-frequenz

What's needed?

Replace operator == in https://github.com/frequenz-floss/frequenz-sdk-python/blob/v1.x.x/tests/actor/test_data_sourcing.py to compare floating-point values against the result of addition operations involving floating-point numbers.

Proposed solution

Use isclose() from pytest or math instead.

Additional context

This is a follow-up from a code review: https://github.com/frequenz-floss/frequenz-sdk-python/pull/955/files#r1630265422

Metadata

Metadata

Assignees

No one assigned

    Labels

    part:testsAffects the unit, integration and performance (benchmarks) testspriority:lowThis should be addressed only if there is nothing else on the tabletype:enhancementNew feature or enhancement visitble to users

    Type

    No type

    Projects

    Status

    To do

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions