Skip to content

Commit 32c455d

Browse files
authored
Merge pull request #209 from clue-labs/mysql8+
Update test matrix to include full MySQL 8 and MySQL 9 support
2 parents a134348 + a268ec3 commit 32c455d

File tree

3 files changed

+12
-1
lines changed

3 files changed

+12
-1
lines changed

.github/workflows/ci.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,10 @@ jobs:
2727
- 5.5
2828
- 5.4
2929
include:
30+
- php: 8.4
31+
rdbms: mysql:9
32+
- php: 8.4
33+
rdbms: mysql:8
3034
- php: 8.4
3135
rdbms: mariadb:10
3236
steps:

README.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -416,6 +416,12 @@ extensions and supports running on legacy PHP 5.4 through current PHP 8+ and
416416
HHVM.
417417
It's *highly recommended to use the latest supported PHP version* for this project.
418418

419+
This project supports connecting to a variety of MySQL database versions and
420+
compatible projects using the MySQL protocol. The `caching_sha2_password`
421+
authentication plugin (default in MySQL 8+) requires PHP 7.1+ and `ext-openssl`
422+
to be installed, while the older `mysql_native_password` authentication plugin
423+
(default in MySQL 5.7) is supported across all supported PHP versions.
424+
419425
## Tests
420426

421427
To run the test suite, you first need to clone this repo and then install all

tests/NoResultQueryTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,8 @@ public function testCreateTableAgainWillAddWarning()
7676
)';
7777

7878
$connection->query($sql)->then(function (MysqlResult $command) {
79-
$this->assertEquals(1, $command->warningCount);
79+
// 3 warnings on MySQL 8+, 1 warning on legacy MySQL 5
80+
$this->assertGreaterThanOrEqual(1, $command->warningCount);
8081
});
8182

8283
$connection->quit();

0 commit comments

Comments
 (0)