fix: bind loopback-context for concurrency

Author: Tom Kirkpatrick

lib/middleware/access-logger.js

@@ -1,10 +1,15 @@
 'use strict'
 
+const LoopBackContext = require('loopback-context')
 const debug = require('debug')('loopback:component:access:logger')
 
 module.exports = function accessLoggerMiddleware() {
   debug('initializing access logger middleware')
   return function accessLogger(req, res, next) {
+    const loopbackContext = LoopBackContext.getCurrentContext({ bind: true })
+
+    next = loopbackContext.bind(next)
+
     if (req.accessToken) {
       debug('req: %s %s, token: %o', req.method, req.originalUrl, req.accessToken)
     }

lib/middleware/user-context.js

@@ -8,7 +8,9 @@ module.exports = function userContextMiddleware() {
   debug('initializing user context middleware')
   // set current user to enable user access for remote methods
   return function userContext(req, res, next) {
-    const loopbackContext = LoopBackContext.getCurrentContext()
+    const loopbackContext = LoopBackContext.getCurrentContext({ bind: true })
+
+    next = loopbackContext.bind(next)
 
     if (!loopbackContext) {
       debug('No user context (loopback current context not found)')

lib/mixins/get-current-user.js

@@ -7,7 +7,7 @@ module.exports = function getCurrentUserMixin(Model) {
   debug('initializing GetCurrentUser Mixin for model %s', Model.modelName)
 
   Model.getCurrentUser = function getCurrentUser() {
-    const ctx = LoopBackContext.getCurrentContext()
+    const ctx = LoopBackContext.getCurrentContext({ bind: true })
     const currentUser = (ctx && ctx.get('currentUser')) || null
 
     if (ctx) {

lib/utils.js

@@ -75,7 +75,7 @@ module.exports = class AccessUtils {
             }
 
             // Do not apply filters if no group access acls were applied.
-            const loopbackContext = LoopBackContext.getCurrentContext()
+            const loopbackContext = LoopBackContext.getCurrentContext({ bind: true })
             const groupAccessApplied = Boolean(loopbackContext && loopbackContext.get('groupAccessApplied'))
 
             if (!groupAccessApplied) {
@@ -229,7 +229,7 @@ module.exports = class AccessUtils {
    * @returns {Object} Returns the currently logged in user.
    */
   getCurrentUser() {
-    const ctx = LoopBackContext.getCurrentContext()
+    const ctx = LoopBackContext.getCurrentContext({ bind: true })
     const currentUser = (ctx && ctx.get('currentUser')) || null
 
     return currentUser
@@ -241,7 +241,7 @@ module.exports = class AccessUtils {
    * @returns {Array} Returnds a list of access groups the user is a member of.
    */
   getCurrentUserGroups() {
-    const ctx = LoopBackContext.getCurrentContext()
+    const ctx = LoopBackContext.getCurrentContext({ bind: true })
     const currentUserGroups = (ctx && ctx.get('currentUserGroups')) || []
 
     return currentUserGroups
@@ -296,7 +296,7 @@ module.exports = class AccessUtils {
         return cb.promise
       }
 
-      LoopBackContext.getCurrentContext().set('groupAccessApplied', true)
+      LoopBackContext.getCurrentContext({ bind: true }).set('groupAccessApplied', true)
 
       /**
        * Basic application that does not cover static methods. Similar to $owner. (RECOMMENDED)
@@ -369,7 +369,7 @@ module.exports = class AccessUtils {
 
           // Note the fact that we are allowing access due to passing an ACL.
           if (res) {
-            LoopBackContext.getCurrentContext().set('groupAccessApplied', true)
+            LoopBackContext.getCurrentContext({ bind: true }).set('groupAccessApplied', true)
           }
 
           return cb(null, res)