-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request | Move the Special Rules list #409
Labels
Comments
funilrys
added a commit
that referenced
this issue
Dec 27, 2024
This patch (partially) fixes #409. Indeed, before this patch, end-user couldn't bring their own rules. Therefore, through this patch, we expose part of our internal through a "user-friendly" configuration key. There a room for improvement, but this first version should handle most of the cases.
Super, after reviewing the MR, I have |
Reopening, as I want to make this extensible to solve your use case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is the feature you'd like to request?
I suggest we moves the rules.py contests of:
PyFunceble/PyFunceble/checker/availability/extras/rules.py
Lines 79 to 114 in 8eb12e9
As this is plain json, I suggest this part is giving it's own branch or REPO to avoid waiting to long for updates, You should grant a number of users moderator rights on this files AND the requirements of two moderators approval before it's merge able.
This can remove the stalled time and properly a lot of merge issues such as #404
What problem are you trying to solve?
I'm trying to solve a problem where...
What solution would you like to see?
A single point of "failure" awaiting a single users approval, for something that should be rather flexible for a number of trusted users to merge and maintain, and this list should not be depending on the rest of the pyfunceble project + is can be shared to other project.
Are there any alternatives you've considered?
I've considered alternatives such as...
Additional context
This JSON file should be a JSON5 file, to allow adding comments inside the file, for easier maintenance.
The text was updated successfully, but these errors were encountered: