Skip to content

Commit a845556

Browse files
committed
Some experiments
1 parent 98c438c commit a845556

3 files changed

Lines changed: 6 additions & 5 deletions

File tree

lib/grpmat.gd

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
## <#/GAPDoc>
2828
##
2929
DeclareCategory( "IsMatrixGroup", IsGroup );
30-
InstallTrueMethod( IsMatrixGroup, IsRingElementCollCollColl and IsGroup );
30+
InstallTrueMethod( IsMatrixGroup, IsRingElementCollCollColl and IsGroup ); # TODO
3131

3232
#############################################################################
3333
##

lib/matobj1.gd

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -274,14 +274,14 @@ DeclareCategory( "IsFFEVectorObj", IsVectorObj );
274274
DeclareCategory( "IsCyclotomicVectorObj", IsVectorObj );
275275

276276
DeclareCategory( "IsFFEMatrixOrMatrixObj", IsMatrixOrMatrixObj );
277-
# DeclareSynonym( "IsFFEMatrix", IsFFEMatrixOrMatrixObj and IsMatrix );
277+
DeclareSynonym( "IsFFEMatrix", IsFFEMatrixOrMatrixObj and IsMatrix );
278278
DeclareSynonym( "IsFFEMatrixObj", IsFFEMatrixOrMatrixObj and IsMatrixObj );
279279
# or maybe
280280
# DeclareProperty( "IsFFEMatrix", IsMatrix );
281281
# DeclareProperty( "IsFFEMatrixObj", IsMatrixObj );
282282

283283
DeclareCategory( "IsCyclotomicMatrixOrMatrixObj", IsMatrixOrMatrixObj );
284-
# DeclareSynonym( "IsCyclotomicMatrix", IsCyclotomicMatrixOrMatrixObj and IsMatrix );
284+
DeclareSynonym( "IsCyclotomicMatrix", IsCyclotomicMatrixOrMatrixObj and IsMatrix );
285285
DeclareSynonym( "IsCyclotomicMatrixObj", IsCyclotomicMatrixOrMatrixObj and IsMatrixObj );
286286
# or maybe have them be properties with methods so users are not confused ?!?
287287
# DeclareProperty( "IsCyclotomicMatrix", IsMatrix );

lib/vecmat.gi

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -863,8 +863,9 @@ InstallMethod( InverseOp,
863863
InstallMethod( InverseSameMutability,
864864
"for plain list of GF2 vectors",
865865
true,
866-
[ IsPlistRep and IsFFECollColl and IsMatrix],
867-
0,
866+
[ IsPlistRep and IsFFEMatrixOrMatrixObj],
867+
{} -> RankFilter(IsPlistRep and IsFFECollColl and IsMatrix)
868+
- RankFilter(IsPlistRep and IsFFEMatrixOrMatrixObj),
868869
function(m)
869870
local inv,i;
870871
inv := INV_PLIST_GF2VECS_DESTRUCTIVE(List(m, ShallowCopy));

0 commit comments

Comments
 (0)