Speed up FactorGroup and NaturalHomomorphismByNormalSubgroup for pc groups when the normal subgroup lies in an elementary abelian tail of the pcgs - #6576
Open
fingolfin wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## mh-claude/pc-normal-closure-normality #6576 +/- ##
=========================================================================
+ Coverage 79.02% 79.03% +0.01%
=========================================================================
Files 683 683
Lines 295223 295335 +112
Branches 8637 8661 +24
=========================================================================
+ Hits 233292 233414 +122
+ Misses 60113 60106 -7
+ Partials 1818 1815 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
When the denominator of a modulo pcgs lies in a tail of the numerator that generates an elementary abelian group, exponents above the tail are those of the numerator, and tail exponents follow by reduction with a row-reduced basis of the denominator. IndexOfElementaryAbelianTail finds the tail, for family pcgs from the collector's avector, and GROUP_BY_PCGS_FINITE_ORDERS skips the trivial relations inside it. For a group of order 5^2133 modulo a normal subgroup of order 5^787, building the quotient took about 9 hours and now takes 11.5 s. Assisted-by: Claude Code (Opus 5)
fingolfin
force-pushed
the
mh-claude/pc-factor-perf-handoff-d11831
branch
from
September 16, 2026 07:17
a43f75e to
369070f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the denominator of a modulo pcgs lies in a tail of the numerator that generates an elementary abelian group, exponents above the tail are those of the numerator, and tail exponents follow by reduction with a row-reduced basis of the denominator.
IndexOfElementaryAbelianTailfinds the tail, for family pcgs from the collector's avector, andGROUP_BY_PCGS_FINITE_ORDERSskips the trivial relations inside it.For a group of order 5^2133 modulo a normal subgroup of order 5^787, building the quotient took about 9 hours and now takes 11.5 s.
Assisted-by: Claude Code (Opus 5)