Skip to content

Commit 1a71bad

Browse files
committed
chore: handle properly extensions with case
fixes podman-desktop#6961 Signed-off-by: Florent Benoit <[email protected]>
1 parent 5eeecd8 commit 1a71bad

4 files changed

+7
-5
lines changed

packages/renderer/src/lib/extensions/InstalledExtensionCardLeftLifecycleDelete.spec.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ beforeEach(() => {
3333
test('Expect to delete dd Extension', async () => {
3434
const extension: CombinedExtensionInfoUI = {
3535
type: 'dd',
36-
id: '',
36+
id: 'my.ExtensionId',
3737
name: 'foo',
3838
description: 'my description',
3939
displayName: '',
@@ -54,7 +54,7 @@ test('Expect to delete dd Extension', async () => {
5454
await fireEvent.click(button);
5555

5656
// expect the delete function to be called
57-
expect(vi.mocked(window.ddExtensionDelete)).toHaveBeenCalledWith('foo');
57+
expect(vi.mocked(window.ddExtensionDelete)).toHaveBeenCalledWith('my.ExtensionId');
5858
expect(vi.mocked(window.removeExtension)).not.toHaveBeenCalled();
5959
});
6060

packages/renderer/src/lib/extensions/InstalledExtensionCardLeftLifecycleDelete.svelte

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ let inProgress = false;
1212
async function deleteExtension(): Promise<void> {
1313
inProgress = true;
1414
if (extension.type === 'dd') {
15-
await window.ddExtensionDelete(extension.name);
15+
await window.ddExtensionDelete(extension.id);
1616
} else {
1717
await window.removeExtension(extension.id);
1818
}

packages/renderer/src/stores/all-installed-extensions.spec.ts

+3-2
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ test('combined extensions from DD', async () => {
3737
// now, add some contributions
3838
contributions.set([
3939
{
40-
id: 'first.extension1',
40+
id: 'extension1',
4141
extensionId: 'first.extension1',
4242
description: 'test1',
4343
type: 'hello',
@@ -51,7 +51,7 @@ test('combined extensions from DD', async () => {
5151
version: '1.0.0',
5252
},
5353
{
54-
id: 'second.extension2',
54+
id: 'extension2',
5555
extensionId: 'second.extension2',
5656
description: 'test2',
5757
type: 'hello',
@@ -75,6 +75,7 @@ test('combined extensions from DD', async () => {
7575

7676
expect(extension1?.type).toBe('dd');
7777
expect(extension1?.displayName).toBe('test1');
78+
expect(extension1?.id).toBe('first.extension1');
7879
});
7980

8081
test('combined extensions from PD', async () => {

packages/renderer/src/stores/all-installed-extensions.ts

+1
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ export const combinedInstalledExtensions: Readable<CombinedExtensionInfoUI[]> =
4444
}
4545
return {
4646
...ext,
47+
id: ext.extensionId,
4748
displayName,
4849
type: 'dd',
4950
state: 'started',

0 commit comments

Comments
 (0)