chore(deps): update formatting & linting (#37159)

renovate[bot] · LekoArts · web-flow · commit 5a8879cfb91a · 2022-12-05T11:46:11.000+01:00
Co-authored-by: renovate[bot] &lt;29139614+renovate[bot]@users.noreply.github.com&gt;
Co-authored-by: LekoArts &lt;lekoarts@gmail.com&gt;
diff --git a/.eslintignore b/.eslintignore
@@ -17,6 +17,7 @@ e2e-tests
 examples
 integration-tests
 **/*.d.ts
+deprecated-packages
 
 packages/*/*.js
 packages/gatsby-source-shopify/**/*.js
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -186,14 +186,11 @@ module.exports = {
           },
           {
             selector: `property`,
-            format: [`PascalCase`, `UPPER_CASE`, `camelCase`, `snake_case`],
-            leadingUnderscore: `allowSingleOrDouble`,
+            format: null,
           },
           {
             selector: `objectLiteralProperty`,
-            format: [`PascalCase`, `UPPER_CASE`, `camelCase`, `snake_case`],
-            leadingUnderscore: `allowSingleOrDouble`,
-            trailingUnderscore: `allowSingleOrDouble`,
+            format: null,
           },
           {
             selector: `enum`,
diff --git a/.prettierignore b/.prettierignore
@@ -1,6 +1,7 @@
 *.min.js
 **/node_modules/**
 flow-typed
+deprecated-packages
 
 # webfont demo styles
 **/specimen_files
diff --git a/package.json b/package.json
@@ -2,8 +2,8 @@
   "packageManager": "yarn@1.22.19",
   "devDependencies": {
     "@babel/core": "^7.15.5",
-    "@babel/eslint-parser": "^7.15.4",
-    "@babel/eslint-plugin": "^7.14.0",
+    "@babel/eslint-parser": "^7.19.1",
+    "@babel/eslint-plugin": "^7.19.1",
     "@babel/node": "^7.15.4",
     "@babel/plugin-transform-typescript": "^7.15.4",
     "@babel/runtime": "^7.15.4",
@@ -26,24 +26,24 @@
     "@types/signal-exit": "^3.0.0",
     "@types/stack-trace": "^0.0.29",
     "@types/webpack-merge": "^4.1.5",
-    "@typescript-eslint/eslint-plugin": "^4.33.0",
-    "@typescript-eslint/parser": "^4.33.0",
+    "@typescript-eslint/eslint-plugin": "^5.45.0",
+    "@typescript-eslint/parser": "^5.45.0",
     "babel-jest": "^27.2.1",
     "chalk": "^4.1.2",
     "chokidar": "^3.5.3",
     "cross-env": "^7.0.3",
     "danger": "^10.6.4",
     "date-fns": "^1.30.1",
     "dictionary-en": "^3.1.0",
-    "eslint": "^7.32.0",
+    "eslint": "^8.29.0",
     "eslint-config-google": "^0.14.0",
     "eslint-config-prettier": "^8.5.0",
     "eslint-plugin-filenames": "^1.3.2",
-    "eslint-plugin-flowtype": "^6.1.1",
+    "eslint-plugin-flowtype": "^8.0.3",
     "eslint-plugin-import": "^2.26.0",
     "eslint-plugin-jsx-a11y": "^6.6.1",
     "eslint-plugin-prettier": "^4.2.1",
-    "eslint-plugin-react": "^7.30.1",
+    "eslint-plugin-react": "^7.31.11",
     "fs-extra": "^10.1.0",
     "glob": "^7.2.3",
     "husky": "3.1.0",
@@ -61,7 +61,7 @@
     "node-notifier": "^10.0.0",
     "npm-packlist": "^2.1.5",
     "npm-run-all": "4.1.5",
-    "prettier": "^2.7.1",
+    "prettier": "^2.8.0",
     "rimraf": "^3.0.2",
     "typescript": "^4.7.4",
     "unified": "^9.2.0",
diff --git a/packages/gatsby-plugin-google-analytics/src/index.js b/packages/gatsby-plugin-google-analytics/src/index.js
@@ -1,15 +1,15 @@
 import React from "react"
 import PropTypes from "prop-types"
 
-const createFunctionWithTimeout = (callback, opt_timeout = 1000) => {
+const createFunctionWithTimeout = (callback, optTimeout = 1000) => {
   let called = false
   const raceCallback = () => {
     if (!called) {
       called = true
       callback()
     }
   }
-  setTimeout(raceCallback, opt_timeout)
+  setTimeout(raceCallback, optTimeout)
   return raceCallback
 }
 
diff --git a/packages/gatsby-plugin-mdx/package.json b/packages/gatsby-plugin-mdx/package.json
@@ -28,7 +28,7 @@
   },
   "dependencies": {
     "@mdx-js/mdx": "^2.1.5",
-    "acorn": "^7.4.1",
+    "acorn": "^8.8.1",
     "acorn-jsx": "^5.3.2",
     "astring": "^1.8.3",
     "deepmerge": "^4.2.2",
diff --git a/packages/gatsby-plugin-preact/src/fast-refresh/prefreshGlueCode.js b/packages/gatsby-plugin-preact/src/fast-refresh/prefreshGlueCode.js
@@ -1,4 +1,5 @@
 /* global __prefresh_errors__ */
+/* eslint-disable camelcase */
 import formatWebpackErrors from "./formatWebpackErrors"
 
 const singletonKey = `__webpack_hot_middleware_reporter__`
diff --git a/packages/gatsby-source-wordpress/src/steps/source-nodes/create-nodes/create-local-file-node.js b/packages/gatsby-source-wordpress/src/steps/source-nodes/create-nodes/create-local-file-node.js
@@ -233,6 +233,7 @@ export const createLocalFileNode = async ({
   mediaItemUrl = ensureSrcHasHostname({ wpUrl, src: mediaItemUrl })
 
   const { excludeByMimeTypes, maxFileSizeBytes } =
+    // eslint-disable-next-line no-unsafe-optional-chaining
     pluginOptions.type?.MediaItem?.localFile
 
   // if this file is larger than maxFileSizeBytes, don't fetch the remote file
diff --git a/packages/gatsby-source-wordpress/src/steps/source-nodes/create-nodes/process-node.js b/packages/gatsby-source-wordpress/src/steps/source-nodes/create-nodes/process-node.js
@@ -813,7 +813,7 @@ const replaceFileLinks = async ({
           return null
         }
 
-        const [, hostname, path] = mediaItemMatchGroup?.subMatches
+        const [, hostname, path] = mediaItemMatchGroup.subMatches
 
         cacheCreatedFileNodeBySrc({
           node: mediaItemNode,
diff --git a/packages/gatsby/src/utils/webpack/plugins/static-query-mapper.ts b/packages/gatsby/src/utils/webpack/plugins/static-query-mapper.ts
@@ -21,7 +21,7 @@ export const removeExportQueryParam = (
   if (!path?.includes(`?`)) {
     return path
   }
-  const [filePath, queryParams] = path?.split(`?`)
+  const [filePath, queryParams] = path.split(`?`)
   const params = new URLSearchParams(queryParams)
   params.delete(`export`)
 
diff --git a/packages/gatsby/src/utils/worker/__tests__/schema.ts b/packages/gatsby/src/utils/worker/__tests__/schema.ts
@@ -142,8 +142,9 @@ describe(`worker (schema)`, () => {
   })
 
   it(`should have resolverField from createResolvers`, async () => {
-    // @ts-ignore - it exists
-    const { data } = await worker?.single.getRunQueryResult(`
+    if (!worker) fail(`worker not defined`)
+
+    const { data } = await worker.single.getRunQueryResult(`
     {
       one: nodeTypeOne {
         number
@@ -156,22 +157,27 @@ describe(`worker (schema)`, () => {
       }
     }
   `)
+    if (!data) fail(`data not defined`)
 
+    // @ts-ignore - This is a test
     expect(data.one.number).toBe(123)
     expect(data.two).toBe(null)
+    // @ts-ignore - This is a test
     expect(data.three.resolverField).toBe(`Custom String`)
   })
 
   it(`should have fieldsOnGraphQL from setFieldsOnGraphQLNodeType`, async () => {
-    // @ts-ignore - it exists
-    const { data } = await worker?.single.getRunQueryResult(`
+    if (!worker) fail(`worker not defined`)
+
+    const { data } = await worker.single.getRunQueryResult(`
     {
       four: nodeTypeOne {
         fieldsOnGraphQL
       }
     }
   `)
 
+    // @ts-ignore - This is a test
     expect(data.four.fieldsOnGraphQL).toBe(`Another Custom String`)
   })
 })
diff --git a/yarn.lock b/yarn.lock

Original file line number	Diff line number	Diff line change
`@@ -186,14 +186,11 @@ module.exports = {`
`186`	`186`	`},`
`187`	`187`	`{`
`188`	`188`	selector: `property`,
`189`		- format: [`PascalCase`, `UPPER_CASE`, `camelCase`, `snake_case`],
`190`		- leadingUnderscore: `allowSingleOrDouble`,
	`189`	`+ format: null,`
`191`	`190`	`},`
`192`	`191`	`{`
`193`	`192`	selector: `objectLiteralProperty`,
`194`		- format: [`PascalCase`, `UPPER_CASE`, `camelCase`, `snake_case`],
`195`		- leadingUnderscore: `allowSingleOrDouble`,
`196`		- trailingUnderscore: `allowSingleOrDouble`,
	`193`	`+ format: null,`
`197`	`194`	`},`
`198`	`195`	`{`
`199`	`196`	selector: `enum`,
Original file line number	Diff line number	Diff line change
`@@ -1,15 +1,15 @@`
`1`	`1`	`import React from "react"`
`2`	`2`	`import PropTypes from "prop-types"`
`3`	`3`
`4`		`-const createFunctionWithTimeout = (callback, opt_timeout = 1000) => {`
	`4`	`+const createFunctionWithTimeout = (callback, optTimeout = 1000) => {`
`5`	`5`	`let called = false`
`6`	`6`	`const raceCallback = () => {`
`7`	`7`	`if (!called) {`
`8`	`8`	`called = true`
`9`	`9`	`callback()`
`10`	`10`	`}`
`11`	`11`	`}`
`12`		`- setTimeout(raceCallback, opt_timeout)`
	`12`	`+ setTimeout(raceCallback, optTimeout)`
`13`	`13`	`return raceCallback`
`14`	`14`	`}`
`15`	`15`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`/* global __prefresh_errors__ */`
	`2`	`+/* eslint-disable camelcase */`
`2`	`3`	`import formatWebpackErrors from "./formatWebpackErrors"`
`3`	`4`
`4`	`5`	const singletonKey = `__webpack_hot_middleware_reporter__`
Original file line number	Diff line number	Diff line change
`@@ -813,7 +813,7 @@ const replaceFileLinks = async ({`
`813`	`813`	`return null`
`814`	`814`	`}`
`815`	`815`
`816`		`- const [, hostname, path] = mediaItemMatchGroup?.subMatches`
	`816`	`+ const [, hostname, path] = mediaItemMatchGroup.subMatches`
`817`	`817`
`818`	`818`	`cacheCreatedFileNodeBySrc({`
`819`	`819`	`node: mediaItemNode,`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ export const removeExportQueryParam = (`
`21`	`21`	if (!path?.includes(`?`)) {
`22`	`22`	`return path`
`23`	`23`	`}`
`24`		- const [filePath, queryParams] = path?.split(`?`)
	`24`	+ const [filePath, queryParams] = path.split(`?`)
`25`	`25`	`const params = new URLSearchParams(queryParams)`
`26`	`26`	params.delete(`export`)
`27`	`27`