Skip to content

Commit 27581dc

Browse files
author
Bl00D4NGEL
committed
chore: migrate phpunit config, remove deprecated/unused phpstan configuration, fixed command / bundle to respect symfony 7.0 changes
1 parent be7e05f commit 27581dc

File tree

4 files changed

+19
-29
lines changed

4 files changed

+19
-29
lines changed

phpstan.neon

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ includes:
44

55
parameters:
66
level: max
7-
checkGenericClassInNonGenericObjectType: false
87
paths:
98
- src
109
- tests

phpunit.xml

Lines changed: 15 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,17 @@
11
<?xml version="1.0" encoding="UTF-8"?>
2-
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
3-
xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.0/phpunit.xsd"
4-
bootstrap="vendor/autoload.php"
5-
cacheDirectory=".phpunit.cache"
6-
executionOrder="depends,defects"
7-
requireCoverageMetadata="false"
8-
beStrictAboutCoverageMetadata="false"
9-
beStrictAboutOutputDuringTests="false"
10-
failOnRisky="true"
11-
failOnWarning="true">
12-
<testsuites>
13-
<testsuite name="default">
14-
<directory>tests</directory>
15-
</testsuite>
16-
</testsuites>
17-
18-
<php>
19-
<env name="SODIUM_PUBLIC_KEY" value="o4iljDHUlCgdRxeiz3fkO3oAejq8/pz416xn0KeSjXI="></env>
20-
<env name="SODIUM_PRIVATE_KEY" value="zOfeiHTFd0mWtZ/jyxEk+HM2Hxzh5HVLOTIPuFFAuQk="></env>
21-
</php>
22-
23-
<coverage>
24-
<include>
25-
<directory suffix=".php">src</directory>
26-
</include>
27-
</coverage>
2+
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.5/phpunit.xsd" bootstrap="vendor/autoload.php" cacheDirectory=".phpunit.cache" executionOrder="depends,defects" requireCoverageMetadata="false" beStrictAboutCoverageMetadata="false" beStrictAboutOutputDuringTests="false" failOnRisky="true" failOnWarning="true">
3+
<testsuites>
4+
<testsuite name="default">
5+
<directory>tests</directory>
6+
</testsuite>
7+
</testsuites>
8+
<php>
9+
<env name="SODIUM_PUBLIC_KEY" value="o4iljDHUlCgdRxeiz3fkO3oAejq8/pz416xn0KeSjXI="/>
10+
<env name="SODIUM_PRIVATE_KEY" value="zOfeiHTFd0mWtZ/jyxEk+HM2Hxzh5HVLOTIPuFFAuQk="/>
11+
</php>
12+
<source>
13+
<include>
14+
<directory suffix=".php">src</directory>
15+
</include>
16+
</source>
2817
</phpunit>

src/Command/GenerateKeysCommand.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ protected function configure(): void
2020
;
2121
}
2222

23-
protected function execute(InputInterface $input, OutputInterface $output)
23+
protected function execute(InputInterface $input, OutputInterface $output): int
2424
{
2525
if (\extension_loaded('sodium') === false) {
2626
$output->writeln("<error>The sodium extension is not loaded. Please install and enable it.</error>");

src/GeekCellSodiumBundle.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,8 @@ public function boot(): void
4040
{
4141
parent::boot();
4242

43-
Facade::setContainer($this->container);
43+
if ($this->container) {
44+
Facade::setContainer($this->container);
45+
}
4446
}
4547
}

0 commit comments

Comments
 (0)