Skip to content

Commit 60f96f2

Browse files
authored
docs: update templates (#9)
* fix: add missing permissions and fix example * Update templates * Update templates
1 parent 8401743 commit 60f96f2

File tree

8 files changed

+72
-35
lines changed

8 files changed

+72
-35
lines changed

.github/dependabot.yml

+32
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
---
2+
##############################
3+
## Dependabot configuration ##
4+
##############################
5+
6+
#
7+
# Documentation:
8+
# https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuring-dependabot-version-updates
9+
#
10+
11+
version: 2
12+
updates:
13+
# Maintain dependencies for GitHub Actions
14+
- package-ecosystem: "github-actions"
15+
directory: "/"
16+
schedule:
17+
interval: "daily"
18+
open-pull-requests-limit: 0
19+
20+
# Maintain dependencies for Terraform Providers
21+
- package-ecosystem: "terraform"
22+
directory: "/"
23+
schedule:
24+
interval: "daily"
25+
open-pull-requests-limit: 0
26+
27+
# Maintain dependencies for Golang
28+
- package-ecosystem: "gomod"
29+
directory: "/"
30+
schedule:
31+
interval: "daily"
32+
open-pull-requests-limit: 0

.github/pull_request-template.md

-4
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,6 @@
55

66
...
77

8-
## How this PR fixes it
9-
10-
...
11-
128
## Readiness Checklist
139

1410
### Author/Contributor

README.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -45,15 +45,15 @@ for creating the AWS Integration role and the following submodules:
4545

4646
### Metric collection
4747
* Metric polling (out of the box with integration role)
48-
* Metric streams with Kinesis Firehose
48+
* [Metric streams with Kinesis Firehose](./modules/metric\_streams/README.md)
4949

5050
### Resource collection
5151
* Cloud Security Posture Management (can be enabled via the integration role)
5252

53-
### ECS Fargate Agent
53+
### [ECS Fargate Agent:](./modules/fargate\_agent/README.md)
5454
* Scrape DB metrics for DBM
5555

56-
### Log Forwarder Lambda
56+
### [Log Forwarder Lambda:](./modules/log\_forwarder/README.md)
5757
* Forward any S3 or CloudWatch logs to Datadog
5858

5959
## Inputs
@@ -87,7 +87,7 @@ for creating the AWS Integration role and the following submodules:
8787

8888
## Resources
8989

90-
- resource.aws_iam_role_policy_attachment.csp (main.tf#159)
90+
- resource.aws_iam_role_policy_attachment.csp (main.tf#161)
9191
- resource.datadog_integration_aws.main (main.tf#28)
9292
- data source.aws_caller_identity.current (main.tf#20)
9393

main.tf

+7-5
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,15 @@
66
*
77
* ### Metric collection
88
* * Metric polling (out of the box with integration role)
9-
* * Metric streams with Kinesis Firehose
9+
* * [Metric streams with Kinesis Firehose](./modules/metric_streams/README.md)
1010
*
1111
* ### Resource collection
1212
* * Cloud Security Posture Management (can be enabled via the integration role)
1313
*
14-
* ### ECS Fargate Agent
14+
* ### [ECS Fargate Agent:](./modules/fargate_agent/README.md)
1515
* * Scrape DB metrics for DBM
1616
*
17-
* ### Log Forwarder Lambda
17+
* ### [Log Forwarder Lambda:](./modules/log_forwarder/README.md)
1818
* * Forward any S3 or CloudWatch logs to Datadog
1919
*/
2020
data "aws_caller_identity" "current" {
@@ -40,7 +40,8 @@ resource "datadog_integration_aws" "main" {
4040
}
4141

4242
module "integration_role" {
43-
source = "github.com/geekcell/terraform-aws-iam-role?ref=v1.0"
43+
source = "geekcell/iam-role/aws"
44+
version = ">= 1.0.0, < 2.0.0"
4445

4546
name = local.datadog_integration_role_name
4647
use_name_prefix = false
@@ -63,7 +64,8 @@ module "integration_role" {
6364
}
6465

6566
module "integration_policy" {
66-
source = "github.com/geekcell/terraform-aws-iam-policy?ref=v1.0"
67+
source = "geekcell/iam-policy/aws"
68+
version = ">= 1.0.0, < 2.0.0"
6769

6870
name = "${var.prefix}-datadog-integration"
6971
description = "Policy for Datadog AWS Integration"

modules/fargate_agent/README.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,9 @@ having to setup an EC2 instance. For more information, see: https://docs.datadog
4949

5050
## Resources
5151

52-
- resource.aws_ecs_service.main (modules/fargate_agent/main.tf#44)
53-
- resource.aws_iam_role_policy_attachment.ecs_exec_ssm_policy (modules/fargate_agent/main.tf#96)
54-
- resource.aws_secretsmanager_secret.main (modules/fargate_agent/main.tf#71)
52+
- resource.aws_ecs_service.main (modules/fargate_agent/main.tf#46)
53+
- resource.aws_iam_role_policy_attachment.ecs_exec_ssm_policy (modules/fargate_agent/main.tf#99)
54+
- resource.aws_secretsmanager_secret.main (modules/fargate_agent/main.tf#73)
5555

5656
# Examples
5757
### Full

modules/fargate_agent/main.tf

+6-3
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@
66
* having to setup an EC2 instance. For more information, see: https://docs.datadoghq.com/database_monitoring/
77
*/
88
module "ecs_agent_container" {
9-
source = "github.com/geekcell/terraform-aws-ecs-container-definition?ref=v1"
9+
source = "geekcell/ecs-container-definition/aws"
10+
version = ">= 1.0.0, < 2.0.0"
1011

1112
name = "datadog-agent"
1213
image = var.agent_container
@@ -26,7 +27,8 @@ module "ecs_agent_container" {
2627
}
2728

2829
module "ecs_task_definition" {
29-
source = "github.com/geekcell/terraform-aws-ecs-task-definition.git?ref=v1"
30+
source = "geekcell/ecs-task-definition/aws"
31+
version = ">= 1.0.0, < 2.0.0"
3032

3133
name = var.name
3234
container_definitions = [module.ecs_agent_container.hcl]
@@ -78,7 +80,8 @@ resource "aws_secretsmanager_secret" "main" {
7880
module "ecs_exec_ssm_policy" {
7981
count = length(var.secretsmanager_secret_keys) > 0 ? 1 : 0
8082

81-
source = "github.com/geekcell/terraform-aws-iam-policy?ref=v1"
83+
source = "geekcell/iam-policy/aws"
84+
version = ">= 1.0.0, < 2.0.0"
8285

8386
name = "${var.name}-ssm-env"
8487
statements = [

modules/metrics_firehose/README.md

+12-12
Original file line numberDiff line numberDiff line change
@@ -34,16 +34,16 @@ No outputs.
3434

3535
## Resources
3636

37-
- resource.aws_cloudwatch_log_group.main (modules/metrics_firehose/main.tf#308)
38-
- resource.aws_cloudwatch_log_stream.http_endpoint (modules/metrics_firehose/main.tf#315)
39-
- resource.aws_cloudwatch_log_stream.s3_backup (modules/metrics_firehose/main.tf#320)
40-
- resource.aws_cloudwatch_metric_stream.main (modules/metrics_firehose/main.tf#103)
41-
- resource.aws_kinesis_firehose_delivery_stream.main (modules/metrics_firehose/main.tf#257)
42-
- resource.aws_s3_bucket.main (modules/metrics_firehose/main.tf#328)
43-
- resource.aws_s3_bucket_acl.main (modules/metrics_firehose/main.tf#334)
44-
- resource.aws_s3_bucket_lifecycle_configuration.main (modules/metrics_firehose/main.tf#358)
45-
- resource.aws_s3_bucket_policy.main (modules/metrics_firehose/main.tf#371)
46-
- resource.aws_s3_bucket_public_access_block.main (modules/metrics_firehose/main.tf#339)
47-
- resource.aws_s3_bucket_versioning.main (modules/metrics_firehose/main.tf#348)
48-
- data source.aws_iam_policy_document.main (modules/metrics_firehose/main.tf#378)
37+
- resource.aws_cloudwatch_log_group.main (modules/metrics_firehose/main.tf#312)
38+
- resource.aws_cloudwatch_log_stream.http_endpoint (modules/metrics_firehose/main.tf#319)
39+
- resource.aws_cloudwatch_log_stream.s3_backup (modules/metrics_firehose/main.tf#324)
40+
- resource.aws_cloudwatch_metric_stream.main (modules/metrics_firehose/main.tf#107)
41+
- resource.aws_kinesis_firehose_delivery_stream.main (modules/metrics_firehose/main.tf#261)
42+
- resource.aws_s3_bucket.main (modules/metrics_firehose/main.tf#332)
43+
- resource.aws_s3_bucket_acl.main (modules/metrics_firehose/main.tf#338)
44+
- resource.aws_s3_bucket_lifecycle_configuration.main (modules/metrics_firehose/main.tf#362)
45+
- resource.aws_s3_bucket_policy.main (modules/metrics_firehose/main.tf#375)
46+
- resource.aws_s3_bucket_public_access_block.main (modules/metrics_firehose/main.tf#343)
47+
- resource.aws_s3_bucket_versioning.main (modules/metrics_firehose/main.tf#352)
48+
- data source.aws_iam_policy_document.main (modules/metrics_firehose/main.tf#382)
4949
<!-- END_TF_DOCS -->

modules/metrics_firehose/main.tf

+8-4
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@
66
* for more information.
77
*/
88
module "firehose_role" {
9-
source = "github.com/geekcell/terraform-aws-iam-role?ref=v1"
9+
source = "geekcell/iam-role/aws"
10+
version = ">= 1.0.0, < 2.0.0"
1011

1112
name = "${var.prefix}-datadog-firehose"
1213
description = "Role for Datadog Kinesis Firehose Metric Streams."
@@ -21,7 +22,8 @@ module "firehose_role" {
2122
}
2223

2324
module "firehose_policy" {
24-
source = "github.com/geekcell/terraform-aws-iam-policy?ref=v1"
25+
source = "geekcell/iam-policy/aws"
26+
version = ">= 1.0.0, < 2.0.0"
2527

2628
name = "${var.prefix}-datadog-firehose"
2729
description = "Policy for Datadog Kinesis Firehose Metric Streams."
@@ -63,7 +65,8 @@ module "firehose_policy" {
6365
# METRIC STREAM ROLE
6466
#
6567
module "metric_stream_role" {
66-
source = "github.com/geekcell/terraform-aws-iam-role?ref=v1"
68+
source = "geekcell/iam-role/aws"
69+
version = ">= 1.0.0, < 2.0.0"
6770

6871
name = "${var.prefix}-datadog-metric-stream"
6972
description = "Role for Datadog Metric Stream."
@@ -78,7 +81,8 @@ module "metric_stream_role" {
7881
}
7982

8083
module "metric_stream_policy" {
81-
source = "github.com/geekcell/terraform-aws-iam-policy?ref=v1"
84+
source = "geekcell/iam-policy/aws"
85+
version = ">= 1.0.0, < 2.0.0"
8286

8387
name = "${var.prefix}-datadog-metric-stream"
8488
description = "Policy for Datadog Metric Stream."

0 commit comments

Comments
 (0)