Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS builds are broken #13

Closed
elprans opened this issue Jun 22, 2020 · 4 comments
Closed

macOS builds are broken #13

elprans opened this issue Jun 22, 2020 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@elprans
Copy link
Member

elprans commented Jun 22, 2020

The macOS EdgeDB build started failing with the below error for no apparent reason. Need to investigate and fix/workaround. Possibly, replace the use of rsync with an equivalent Python snippet.

2020-06-21T00:50:57.8742850Z rsync: writefd_unbuffered failed to write 4 bytes [sender]: Broken pipe (32)
2020-06-21T00:50:57.8743440Z ABORTING due to invalid path from sender: Library/Frameworks/EdgeDB.framework/Versions/1-alpha4/lib/edgedb-server-1-alpha4/lib/icu/current/Makefile.inc
2020-06-21T00:50:57.8744030Z rsync error: protocol incompatibility (code 2) at /AppleInternal/BuildRoot/Library/Caches/com.apple.xbs/Sources/rsync/rsync-54.120.1/rsync/generator.c(875) [generator=2.6.9]
2020-06-21T00:50:57.8744190Z rsync: connection unexpectedly closed (72 bytes received so far) [sender]
2020-06-21T00:50:57.8744760Z rsync error: error in rsync protocol data stream (code 12) at /AppleInternal/BuildRoot/Library/Caches/com.apple.xbs/Sources/rsync/rsync-54.120.1/rsync/io.c(453) [sender=2.6.9]
2020-06-21T00:50:57.8745270Z gmake: *** [Makefile:9: _artifacts/tmp/stamp/build] Error 12
2020-06-21T00:50:57.8757060Z env -u MAKELEVEL /usr/local/bin/gmake -j4 SHELL=/usr/local/bin/bash failed with exit code 2
@elprans elprans added the bug Something isn't working label Jun 22, 2020
@ambv
Copy link
Contributor

ambv commented Jul 7, 2020

Build is fixed but found another problem: for some reason ln -sf /Library/Frameworks/EdgeDB.framework/Versions/1-alpha4/lib/edgedb-server-1-alpha4/bin/edgedb-server _artifacts/install/edgedb-server/Library/Frameworks/EdgeDB.framework/bin/edgedb-server-1-alpha4 doesn't work and that path in the file list ends up being invalid.

I removed the unversioned shim from the package. I need to replace it with the versioned symlink before closing this.

@ambv
Copy link
Contributor

ambv commented Jul 8, 2020

The symlink problem is fixed. The test nightly run failed on running tests though (the server didn't turn up). I'll be starting another run when geldata/gel#1518 is merged.

@ambv
Copy link
Contributor

ambv commented Jul 8, 2020

I'm looking at the successful run and it still took over 6 seconds for the server to start. We time out at 10. Maybe we should allow for a longer timeout?

@elprans
Copy link
Member Author

elprans commented Jul 8, 2020

Sure, let's give it 20 for a better margin.

@ambv ambv closed this as completed Jul 10, 2020
@ambv ambv reopened this Jul 10, 2020
@ambv ambv closed this as completed Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants