models: Add support for doublesplat (**)

Author: elprans

gel/_internal/_codegen/_models/_pydantic.py

@@ -3914,7 +3914,7 @@ def _write_object_type_qb_methods(
         builtin_str = self.import_name("builtins", "str")
         callable_ = self.import_name("collections.abc", "Callable")
         literal_ = self.import_name("typing", "Literal")
-        literal_star = f'{literal_}["*"]'
+        literal_star = f'{literal_}["*", "**"]'
         tuple_ = self.import_name("builtins", "tuple")
         expr_proto = self.import_name(BASE_IMPL, "ExprCompatible")
         py_const = self.import_name(BASE_IMPL, "PyConstType")

gel/_internal/_qbmodel/_abstract/_base.py

@@ -143,9 +143,11 @@ class AbstractGelModelMeta(GelTypeMeta):
         weakref.WeakValueDictionary[uuid.UUID, type[Any]]
     ] = weakref.WeakValueDictionary()
 
-    if TYPE_CHECKING:
-        # Splat qb protocol
-        def __iter__(cls) -> Iterator[_qb.ShapeElement]: ...
+    # Splat qb protocol
+    def __iter__(cls) -> Iterator[_qb.ShapeElement]:
+        cls = cast("type[AbstractGelModel]", cls)
+        shape = _qb.get_object_type_splat(cls)
+        return iter(shape.elements)
 
     def __new__(
         mcls,

gel/_internal/_qbmodel/_abstract/_expressions.py

@@ -117,7 +117,7 @@ def _const_to_expr(
 def select(
     cls: type[AbstractGelModel],
     /,
-    *elements: _qb.ShapeElement | Literal["*"],
+    *elements: _qb.ShapeElement | Literal["*", "**"],
     __operand__: _qb.ExprAlias | None = None,
     **kwargs: bool | _Value,
 ) -> _qb.ShapeOp:
@@ -144,6 +144,12 @@ def select(
     for elem in elements:
         if elem == "*":
             shape_elements.extend(iter(cls))
+        elif elem == "**":
+            shape_elements.extend(
+                _qb.Shape.splat(
+                    source=this_type, kind=_qb.Splat.DOUBLESTAR
+                ).elements
+            )
         else:
             shape_elements.append(elem)
 

gel/_internal/_qbmodel/_abstract/_methods.py

@@ -89,7 +89,7 @@ def __gel_assert_single__(
         def select(
             cls,
             /,
-            *elements: _qb.PathAlias | Literal["*"],
+            *elements: _qb.PathAlias | Literal["*", "**"],
             __operand__: _qb.ExprAlias | None = None,
             **kwargs: Any,
         ) -> type[Self]:

gel/_internal/_qbmodel/_pydantic/_models.py

@@ -50,10 +50,7 @@
 from . import _fields
 
 if TYPE_CHECKING:
-    from collections.abc import (
-        Iterator,
-        Mapping,
-    )
+    from collections.abc import Mapping
     from gel._internal._qbmodel._abstract import GelType
 
 
@@ -276,12 +273,6 @@ def __setattr__(cls, name: str, value: Any, /) -> None:  # noqa: N805
         else:
             super().__setattr__(name, value)
 
-    # Splat qb protocol
-    def __iter__(cls) -> Iterator[_qb.ShapeElement]:  # noqa: N805
-        cls = cast("type[GelModel]", cls)
-        shape = _qb.get_object_type_splat(cls)
-        return iter(shape.elements)
-
     def __gel_pointers__(cls) -> Mapping[str, type[GelType]]:  # noqa: N805
         cls = cast("type[GelModel]", cls)
         result = _model_pointers_cache.get(cls)

tests/test_qb.py

@@ -294,7 +294,6 @@ def test_qb_filter_06(self):
         self.assertEqual(res.name, "red")
         self.assertEqual(res.count, 2)
 
-    @tb.xfail
     def test_qb_filter_07(self):
         from models import default
 
@@ -693,7 +692,6 @@ def test_qb_delete_02(self):
             [p.body for p in after], ["*magic stuff*", "I'm Cameron"]
         )
 
-    @tb.xfail
     def test_qb_delete_03(self):
         from models import default