Skip to content

Can't type the letter i in Notebooks when JupyterGIS is installed #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mfisher87 opened this issue Apr 1, 2025 · 2 comments · Fixed by #603
Closed

Can't type the letter i in Notebooks when JupyterGIS is installed #592

mfisher87 opened this issue Apr 1, 2025 · 2 comments · Fixed by #603
Labels
bug Something isn't working
Milestone
0.5.0

Comments

@mfisher87
Copy link
Member

mfisher87 commented Apr 1, 2025 •
edited
Loading

I can't type the letter i into a Notebook when JupyterGIS is installed. There is no JupyterGIS document open, and both the left and right JupyterGIS panels are closed.

Looks like the "selector" logic for keybindings isn't working as expected! This was introduced in #581 , and reverting it resolves the problem.
@mfisher87 mfisher87 added the bug Something isn't working label Apr 1, 2025
@mfisher87 mfisher87 added this to the 0.5.0 milestone Apr 1, 2025
@mfisher87 mfisher87 changed the title Can't type the letter i when JupyterGIS is installed Can't type the letter i in Notebooks when JupyterGIS is installed Apr 1, 2025
@martinRenou
Copy link
Member

That's pretty bad :D We should work on a fix today during the hackathon

@mfisher87
Copy link
Member Author

Since we focused on something else at the hackathon today (#596), I'll open a PR to revert this change and re-open the issue to re-implement it once we've figured out the selector bug.

mfisher87 added a commit to mfisher87/jupytergis that referenced this issue Apr 2, 2025
@mfisher87
Change identify keybinding to work around bug geojupyter#592
79eaa6b 
See: <geojupyter#592>
@mfisher87 mfisher87 mentioned this issue Apr 2, 2025
Merged
4 tasks
martinRenou pushed a commit that referenced this issue Apr 3, 2025
@mfisher87
Change identify keybinding to work around bug #592 (#600)
5e86591 
See: <#592>
@arjxn-py arjxn-py mentioned this issue Apr 4, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.5.0
Development

Successfully merging a pull request may close this issue.

Use only relevant selectors for keybindings to prevent conflicts arjxn-py/jupytergis
2 participants
@mfisher87 @martinRenou