BUG: fix Time type columns being skipped with arrow=False #617
+18
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olumns-being-skipped-with-arrow=False
Member
|
Updated after merging the other PR |
…olumns-being-skipped-with-arrow=False
…e' of https://github.com/theroggy/pyogrio into BUG-fix-Time-type-columns-being-skipped-with-arrow=False
Member
Author
|
I put the PR back in progress because I noticed while "backporting" the roundtrip-test from the other PR there was some weird behaviour with the "time" column not being written with Long story short: apparently there was a bug in GDAL < 3.11 that "time"-type columns were not written with Now it should be fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #615