Skip to content

Conversation

@kieranbartels
Copy link

Overview

This PR filters out non-spatiotemporal parameters (e.g., crs, lat_bounds, other auxiliary variables) from collections so they are not treated as queryable parameters during position queries or displayed in the collection's Parameters table.

This resolves the issue where pygeoapi attempts to collect timeseries data for fields like crs, causing:

  • The position query UI popup to render blank.
  • Invalid parameters (with "None" values) to appear in the collection's Parameters table.

After filtering these fields, position queries behave correctly, and the Parameter table only lists actual geospatial/temporal variables.


Related Issue / discussion


Dependency policy (RFC2)

  • I have ensured that this PR meets RFC2 requirements

Updates to public demo

Contributions and licensing

(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to pygeoapi. I confirm that my contributions to pygeoapi will be compatible with the pygeoapi license guidelines at the time of contribution
  • I have already previously agreed to the pygeoapi Contributions and Licensing Guidelines

- filters out any non-geospatial data fields (i.e. crs, lat_bounds)
- fixes the UI position query issue caused by attempting to query timeseries data on the crs field
- still need to test compatibility with the builder
@webb-ben
Copy link
Member

I am not sure of the relative performance differences but I had implemented https://github.com/internetofwater/pygeoapi/blob/e6b12b0224163f4eaf5c58f37049f44fc8dc77e8/pygeoapi/provider/xarray_.py#L120-L122 to continue when no units were found.

Not understanding OACov enough to say confidently if this is a patch for xarray_.py or xarray_edr.py. I assume even though the error surfaces in an EDR query, the logics stands that these are also required fields in a coverage?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants