Fix WMTSFacade provider #2167
Fix WMTSFacade provider #2167
Conversation
'style' query parameter is mandatory according to WMTS 1.0.0 standard. For backwards compatibility, empty string remains as default value.
There was a problem hiding this comment.
@Dolite Thank You for this enhancement to the provider, by exposing the style parameter, which currently is set to ' ' . When this parameter is empty, the server always fallbacks to the default style; In my comment I suggest you update the description on the documentation to make this behaviour more clear.
Please note that this is not a bug, as the provider does not necessarily need to expose all the mandatory parameters of WMTS; I think keeping it optional, as you did, is a good idea; to support backwards compatibility and also to make configuration easier for the users.
| options: | ||
| wmts_layer: camb:hex350_grid_mental_1920 # the layer name of the wmts | ||
| wmts_tile_matrix_set: WebMercatorQuad # the name of the tile matrix set of the wmts. | ||
| wmts_style: camb:hex350_grid_mental_1920 # the style identifier of the wmts. Default to empty |
There was a problem hiding this comment.
"Default to empty"-> "if empty or this key is missing, it falls back to the default style."
There was a problem hiding this comment.
@Dolite would you mind just updating the comment here, so we can merge the PR? Thank You 🙏🏽
| 'tileMatrix': z, | ||
| 'tileRow': y, | ||
| 'tileCol': x, | ||
| 'style': '' |
There was a problem hiding this comment.
The current code base is passing the mandatory "style" parameter to WMTS, but not exposing it to the user.
2 participants
'style' query parameter is mandatory according to WMTS 1.0.0 standard. For backwards compatibility, empty string remains as default value.
Overview
Related Issue / discussion
Additional information
Dependency policy (RFC2)
Updates to public demo
Contributions and licensing
(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)