Skip to content

Commit 04478cf

Browse files
fix(ci): drop go work sync, use workspace root for go test
go work sync tries to resolve local modules from the module proxy, which fails for core@v0.0.0 since the module is not yet published. It is not needed here: running go test/vet from the workspace root is enough — Go finds go.work, resolves local modules via use directives, downloads external deps from the proxy, and verifies checksums via go.work.sum. Also removes -mod=mod which is not allowed in workspace mode.
1 parent a0a60cb commit 04478cf

3 files changed

Lines changed: 5 additions & 14 deletions

File tree

.github/workflows/ci.yml

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -18,19 +18,15 @@ jobs:
1818
- uses: actions/setup-go@v5
1919
with:
2020
go-version: ${{ matrix.go }}
21-
# Download all workspace dependencies in one pass.
22-
# -mod=mod allows Go to update go.sum files as needed.
23-
- name: Download dependencies
24-
run: go work sync
2521
- name: Test all modules (unit)
26-
run: go test -mod=mod ./...
22+
run: go test ./...
2723
- name: Test core (integration)
28-
run: go test -mod=mod -tags integration ./core/...
24+
run: go test -tags integration ./core/...
2925
env:
3026
GOOGLE_CREDS_B64: ${{ secrets.GOOGLE_CREDS_B64 }}
3127
SKIPPER_SPREADSHEET_ID: ${{ secrets.SKIPPER_SPREADSHEET_ID }}
3228
- name: Test framework modules with live spreadsheet
33-
run: go test -mod=mod ./testing/... ./testify/... ./ginkgo/...
29+
run: go test ./testing/... ./testify/... ./ginkgo/...
3430
env:
3531
GOOGLE_CREDS_B64: ${{ secrets.GOOGLE_CREDS_B64 }}
3632
SKIPPER_SPREADSHEET_ID: ${{ secrets.SKIPPER_SPREADSHEET_ID }}
@@ -43,7 +39,5 @@ jobs:
4339
- uses: actions/setup-go@v5
4440
with:
4541
go-version: '1.23'
46-
- name: Download dependencies
47-
run: go work sync
4842
- name: Vet all modules
49-
run: go vet -mod=mod ./...
43+
run: go vet ./...

.github/workflows/sync.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,8 @@ jobs:
1313
- uses: actions/setup-go@v5
1414
with:
1515
go-version: '1.23'
16-
- name: Download dependencies
17-
run: go work sync
1816
- name: Sync spreadsheet
19-
run: go test -mod=mod -tags integration ./core/...
17+
run: go test -tags integration ./core/...
2018
env:
2119
SKIPPER_MODE: sync
2220
GOOGLE_CREDS_B64: ${{ secrets.GOOGLE_CREDS_B64 }}

Makefile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ lint:
1717
go vet ./...
1818

1919
tidy:
20-
go work sync
2120
@for m in $(MODULES); do \
2221
echo "==> Tidying $$m"; \
2322
(cd $$m && go mod tidy); \

0 commit comments

Comments
 (0)