Skip to content

Commit 1dc4147

Browse files
authored
Merge pull request #2115 from get10101/chore/reduce-rounding-borders
chore(app): Reduce rounding on the status dialog
2 parents 0c45e66 + 5697ff0 commit 1dc4147

File tree

2 files changed

+3
-16
lines changed

2 files changed

+3
-16
lines changed

Diff for: mobile/lib/common/task_status_dialog.dart

+1
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@ class _TaskStatusDialog extends State<TaskStatusDialog> {
7878
child: Text(widget.buttonText));
7979

8080
AlertDialog dialog = AlertDialog(
81+
shape: const RoundedRectangleBorder(borderRadius: BorderRadius.all(Radius.circular(12.0))),
8182
icon: (() {
8283
switch (widget.status) {
8384
case TaskStatus.pending:

Diff for: mobile/lib/features/trade/trade_dialog.dart

+2-16
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import 'dart:convert';
2-
import 'dart:io';
32

43
import 'package:flutter/gestures.dart';
54
import 'package:flutter/material.dart';
@@ -15,7 +14,6 @@ import 'package:get_10101/features/trade/domain/trade_values.dart';
1514
import 'package:get_10101/features/trade/submit_order_change_notifier.dart';
1615
import 'package:provider/provider.dart';
1716
import 'package:share_plus/share_plus.dart';
18-
import 'package:social_share/social_share.dart';
1917
import 'package:url_launcher/url_launcher.dart';
2018

2119
class TradeDialog extends StatelessWidget {
@@ -83,7 +81,7 @@ Widget createSubmitWidget(
8381
SizedBox(
8482
width: 200,
8583
child: Wrap(
86-
runSpacing: 10,
84+
runSpacing: 5,
8785
children: [
8886
pendingOrder.positionAction == PositionAction.close
8987
? ValueDataRow(type: ValueType.amount, value: pendingOrder.pnl, label: pnlText)
@@ -116,7 +114,7 @@ Widget createSubmitWidget(
116114
// Only display "share on twitter" when order is filled
117115
if (pendingOrder.state == PendingOrderState.orderFilled) {
118116
children.add(Padding(
119-
padding: const EdgeInsets.only(top: 20, left: 10, right: 10, bottom: 5),
117+
padding: const EdgeInsets.only(top: 10, left: 10, right: 10),
120118
child: ElevatedButton(
121119
onPressed: () async {
122120
showDialog(
@@ -150,18 +148,6 @@ Widget createSubmitWidget(
150148
);
151149
}
152150

153-
Future<void> shareTweet(PositionAction action) async {
154-
String actionStr = action == PositionAction.open ? "opened" : "closed";
155-
String shareText =
156-
"Just $actionStr a #selfcustodial position using #DLC with @get10101 🚀. The future of decentralised finance starts now! #Bitcoin";
157-
158-
if (Platform.isAndroid || Platform.isIOS) {
159-
await SocialShare.shareTwitter(shareText);
160-
} else {
161-
await Share.share(shareText);
162-
}
163-
}
164-
165151
class ClickableHelpText extends StatelessWidget {
166152
const ClickableHelpText({super.key});
167153

0 commit comments

Comments
 (0)