Skip to content

Commit 95fb796

Browse files
fixup! views: add series-detail view
1 parent 6eb5ae4 commit 95fb796

File tree

2 files changed

+17
-5
lines changed

2 files changed

+17
-5
lines changed

patchwork/models.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -962,10 +962,10 @@ def add_patch(self, patch, number):
962962
return patch
963963

964964
def get_absolute_url(self):
965-
# TODO(stephenfin): We really need a proper series view
966965
return reverse(
967-
'patch-list', kwargs={'project_id': self.project.linkname}
968-
) + ('?series=%d' % self.id)
966+
'series-detail',
967+
kwargs={'project_id': self.project.linkname, 'series_id': self.id},
968+
)
969969

970970
def get_mbox_url(self):
971971
return reverse('series-mbox', kwargs={'series_id': self.id})

patchwork/templates/patchwork/series-detail.html

+14-2
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,11 @@ <h1>{{ series.name }}</h1>
1717

1818
<table class="patch-meta">
1919
<tr>
20-
<th>Cover Letter</th>
21-
<td>{{ series.cover_letter.content|default:"No cover letter available" }}</td>
20+
<th>Series ID</th>
21+
<td>
22+
{{ series.id }}
23+
<span class="btn-link btn-copy glyphicon glyphicon-copy" data-clipboard-text="{{ request.build_absolute_uri }}{{ series.get_absolute_url }}" title="Copy to Clipboard"></span>
24+
</td>
2225
</tr>
2326
<tr>
2427
<th>Date</th>
@@ -38,4 +41,13 @@ <h2>Patches</h2>
3841
<br>
3942
{% include "patchwork/partials/patch-list.html" %}
4043

44+
<div id="cover-letter">
45+
<h2>Cover Letter</h2>
46+
{% if series.cover_letter.content %}
47+
<pre class="content">{{ series.cover_letter.content }}</pre>
48+
{% else %}
49+
No cover letter available
50+
{% endif %}
51+
</div>
52+
4153
{% endblock %}

0 commit comments

Comments
 (0)