fix: Stop SessionReplay when closing SDK (#3941)

Call SessionReplay.stop when uninstalling the SDK and invalidate the
DisplayLinkWrapper when SessionReplay gets deallocated.

Author: philipphofmann

CHANGELOG.md

@@ -6,6 +6,7 @@
 
 - Ignore SentryFramesTracker thread sanitizer data races (#3922)
 - Handle no releaseName in WatchDogTerminationLogic (#3919)
+- Stop SessionReplay when closing SDK (#3941)
 
 ### Improvements
 

Sources/Sentry/SentrySessionReplay.m

@@ -114,6 +114,11 @@ - (void)stop
     }
 }
 
+- (void)dealloc
+{
+    [self stop];
+}
+
 - (void)captureReplayForEvent:(SentryEvent *)event;
 {
     if (!_isRunning) {

Sources/Sentry/SentrySessionReplayIntegration.m

@@ -139,6 +139,7 @@ - (SentryIntegrationOption)integrationOptions
 
 - (void)uninstall
 {
+    [self stop];
 }
 
 - (BOOL)shouldReplayFullSession:(CGFloat)rate

Tests/SentryTests/Integrations/SessionReplay/SentrySessionReplayTests.swift

@@ -208,6 +208,17 @@ class SentrySessionReplayTests: XCTestCase {
 
         expect(Dynamic(sut).isRunning) == false
     }
+    
+    @available(iOS 16.0, tvOS 16, *)
+    func testDealloc_CallsStop() {
+        let fixture = startFixture()
+        func sutIsDeallocatedAfterCallingMe() {
+            _ = fixture.getSut(options: SentryReplayOptions(sessionSampleRate: 1, errorSampleRate: 1))
+        }
+        sutIsDeallocatedAfterCallingMe()
+        
+        expect(fixture.displayLink.invalidateInvocations.count) == 1
+    }
 
     func assertFullSession(_ sessionReplay: SentrySessionReplay, expected: Bool) {
         expect(Dynamic(sessionReplay).isFullSession) == expected