Merge remote-tracking branch 'origin/main' into philprime/session-replay-inversion-improvements

Author: philprime

.github/workflows/build.yml

@@ -69,9 +69,19 @@ jobs:
           - scheme: macOS-SwiftUI
             xcode: 16.2
             runs-on: macos-15
+
           - scheme: SessionReplay-CameraTest
             xcode: 16.2
             runs-on: macos-15
+
+            # We have to compile on Xcode 16.3 because compiling on Xcode 16.2 fails with
+            # Data+SentryTracing.swift:21:62: error: 'ReadingOptions' aliases 'Foundation.ReadingOptions'
+            # and cannot be used here because C++ types from imported module 'Foundation' do not support
+            # library evolution; this is an error in the Swift 6 language mode
+          - scheme: visionOS-Swift
+            xcode: 16.3
+            runs-on: macos-15
+
     steps:
       - uses: actions/checkout@v4
       - run: ./scripts/ci-select-xcode.sh ${{ matrix.xcode }}

Samples/visionOS-Swift/visionOS-Swift/VisionOSSwiftApp.swift

@@ -9,7 +9,6 @@ struct VisionOSSwiftApp: App {
             options.dsn = "https://[email protected]/5428557"
             options.debug = true
             options.tracesSampleRate = 1.0
-            options.profilesSampleRate = 1.0
             options.attachScreenshot = true
             options.attachViewHierarchy = true
 

Sources/Sentry/SentrySessionReplayIntegration.m

@@ -100,6 +100,8 @@ - (void)setupWith:(SentryReplayOptions *)replayOptions
 {
     _replayOptions = replayOptions;
     _rateLimits = SentryDependencyContainer.sharedInstance.rateLimits;
+    _dateProvider = SentryDependencyContainer.sharedInstance.dateProvider;
+
     id<SentryViewRenderer> viewRenderer;
     if (enableExperimentalRenderer) {
         viewRenderer = [[SentryExperimentalViewRenderer alloc]
@@ -116,9 +118,8 @@ - (void)setupWith:(SentryReplayOptions *)replayOptions
                           enableExperimentalMaskRenderer:enableExperimentalRenderer];
 
     if (touchTracker) {
-        _touchTracker = [[SentryTouchTracker alloc]
-            initWithDateProvider:SentryDependencyContainer.sharedInstance.dateProvider
-                           scale:replayOptions.sizeScale];
+        _touchTracker = [[SentryTouchTracker alloc] initWithDateProvider:_dateProvider
+                                                                   scale:replayOptions.sizeScale];
         [self swizzleApplicationTouch];
     }
 
@@ -137,6 +138,8 @@ - (void)setupWith:(SentryReplayOptions *)replayOptions
         createBackgroundDispatchQueueWithName:"io.sentry.session-replay.processing"
                              relativePriority:-2];
 
+    // The asset worker queue is used to work on video and frames data.
+
     [self moveCurrentReplay];
     [self cleanUp];
 
@@ -267,7 +270,8 @@ - (void)resumePreviousSessionReplay:(SentryEvent *)event
     NSError *_Nullable removeError;
     BOOL result = [NSFileManager.defaultManager removeItemAtURL:lastReplayURL error:&removeError];
     if (result == NO) {
-        SENTRY_LOG_ERROR(@"Can`t delete '%@': %@", SENTRY_LAST_REPLAY, removeError);
+        SENTRY_LOG_ERROR(@"Can't delete '%@' with file item at url: '%@', reason: %@",
+            SENTRY_LAST_REPLAY, lastReplayURL, removeError);
     }
 }
 

Sources/Swift/Integrations/SessionReplay/SentryOnDemandReplay.swift

@@ -119,7 +119,7 @@ class SentryOnDemandReplay: NSObject, SentryReplayVideoMaker {
 
     func releaseFramesUntil(_ date: Date) {
         processingQueue.dispatchAsync {
-            SentryLog.debug("[Session Replay] Releasing frames until date: \(date), current queue: \(self.processingQueue.queue.label)")
+            SentryLog.debug("[Session Replay] Releasing frames until date: \(date)")
             while let first = self._frames.first, first.time < date {
                 self._frames.removeFirst()
                 let fileUrl = URL(fileURLWithPath: first.imagePath)