Commit 248c671
test(log4net): Run the configuration binding tests against log4net 3 (#5651)
The V3 test project links the other test files added in #5592, but not
SentryAppenderConfigurationBindingTests. That file didn't compile against log4net 3, which
marks the XmlElement parameter of XmlConfigurator.Configure as non-nullable. With a
null-forgiving operator on DocumentElement it compiles, so the V3 project now links it and the
Dsn tombstone behavior is pinned on both log4net versions.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>1 parent 9999e9a commit 248c671
2 files changed
Lines changed: 2 additions & 1 deletion
File tree
- test
- Sentry.Log4Net.Tests
- Sentry.Log4Net.V3.Tests
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
42 | | - | |
| 42 | + | |
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
| |||
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
| |||
0 commit comments