Merge branch 'feat/assemblystore-v4' into feat/assemblystore-zstd

Author: jamescrosswell

src/Sentry.Android.AssemblyReader/V2/StoreReader.Classes.cs

@@ -21,7 +21,6 @@ private sealed class Header
         // Index size in bytes
         public readonly uint index_size;
 
-        // Only present in v4+ stores
         public readonly ulong content_id;
 
         public uint NativeSize => 5 * sizeof(uint) + ((version & ASSEMBLY_STORE_FORMAT_NUMBER_MASK) >= 4 ? sizeof(ulong) : 0u);

src/Sentry.Android.AssemblyReader/V2/StoreReader.cs

@@ -12,7 +12,6 @@ namespace Sentry.Android.AssemblyReader.V2;
 internal partial class StoreReader : AssemblyStoreReader
 {
     // Bit 31 is set for 64-bit platforms, cleared for the 32-bit ones
-    // Each .NET release bumps the assembly store format: v3 in .NET 10, v4 (CoreCLR) in .NET 11.
     private const uint ASSEMBLY_STORE_FORMAT_VERSION_64BIT_V3 = 0x80000003;
     private const uint ASSEMBLY_STORE_FORMAT_VERSION_32BIT_V3 = 0x00000003;
     private const uint ASSEMBLY_STORE_FORMAT_VERSION_CORECLR_64BIT_V4 = 0x80000004; // Must match the ASSEMBLY_STORE_FORMAT_VERSION native constant

test/Sentry.Android.AssemblyReader.Tests/StoreReaderTests.cs

@@ -38,9 +38,6 @@ public void Create_UnsupportedVersion_ReturnsNull(uint version)
         reader.Should().BeNull();
     }
 
-    /// <summary>
-    /// Builds a minimal assembly store with a single assembly, using the v3/v4 layout.
-    /// </summary>
     private static MemoryStream CreateStore(uint version, bool is64Bit, string assemblyName)
     {
         var stream = new MemoryStream();