From 2f10f1c467da5a7788632ddc78adf34e252133fa Mon Sep 17 00:00:00 2001 From: Alexander Dinauer Date: Mon, 24 Nov 2025 11:28:00 +0100 Subject: [PATCH 1/3] Do not log if sentry.properties in rundir has not been found --- .../io/sentry/config/FilesystemPropertiesLoader.java | 10 +++++++++- .../io/sentry/config/PropertiesProviderFactory.java | 2 +- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/sentry/src/main/java/io/sentry/config/FilesystemPropertiesLoader.java b/sentry/src/main/java/io/sentry/config/FilesystemPropertiesLoader.java index dcb1ea91009..1cc98d037c7 100644 --- a/sentry/src/main/java/io/sentry/config/FilesystemPropertiesLoader.java +++ b/sentry/src/main/java/io/sentry/config/FilesystemPropertiesLoader.java @@ -14,10 +14,16 @@ final class FilesystemPropertiesLoader implements PropertiesLoader { private final @NotNull String filePath; private final @NotNull ILogger logger; + private boolean logNonExisting; public FilesystemPropertiesLoader(@NotNull String filePath, @NotNull ILogger logger) { + this(filePath, logger, true); + } + + public FilesystemPropertiesLoader(@NotNull String filePath, @NotNull ILogger logger, boolean logNonExisting) { this.filePath = filePath; this.logger = logger; + this.logNonExisting = logNonExisting; } @Override @@ -31,10 +37,12 @@ public FilesystemPropertiesLoader(@NotNull String filePath, @NotNull ILogger log return properties; } } else if (!f.isFile()) { - logger.log( + if (logNonExisting) { + logger.log( SentryLevel.ERROR, "Failed to load Sentry configuration since it is not a file or does not exist: %s", filePath); + } } else if (!f.canRead()) { logger.log( SentryLevel.ERROR, diff --git a/sentry/src/main/java/io/sentry/config/PropertiesProviderFactory.java b/sentry/src/main/java/io/sentry/config/PropertiesProviderFactory.java index 7c9f50facb5..f015522f9e9 100644 --- a/sentry/src/main/java/io/sentry/config/PropertiesProviderFactory.java +++ b/sentry/src/main/java/io/sentry/config/PropertiesProviderFactory.java @@ -58,7 +58,7 @@ public final class PropertiesProviderFactory { } final Properties runDirectoryProperties = - new FilesystemPropertiesLoader("sentry.properties", logger).load(); + new FilesystemPropertiesLoader("sentry.properties", logger, false).load(); if (runDirectoryProperties != null) { providers.add(new SimplePropertiesProvider(runDirectoryProperties)); } From bfe3d16097088a5148b99267fbe22d68573d8bcc Mon Sep 17 00:00:00 2001 From: Sentry Github Bot Date: Mon, 24 Nov 2025 10:33:36 +0000 Subject: [PATCH 2/3] Format code --- .../io/sentry/config/FilesystemPropertiesLoader.java | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/sentry/src/main/java/io/sentry/config/FilesystemPropertiesLoader.java b/sentry/src/main/java/io/sentry/config/FilesystemPropertiesLoader.java index 1cc98d037c7..c896091f006 100644 --- a/sentry/src/main/java/io/sentry/config/FilesystemPropertiesLoader.java +++ b/sentry/src/main/java/io/sentry/config/FilesystemPropertiesLoader.java @@ -20,7 +20,8 @@ public FilesystemPropertiesLoader(@NotNull String filePath, @NotNull ILogger log this(filePath, logger, true); } - public FilesystemPropertiesLoader(@NotNull String filePath, @NotNull ILogger logger, boolean logNonExisting) { + public FilesystemPropertiesLoader( + @NotNull String filePath, @NotNull ILogger logger, boolean logNonExisting) { this.filePath = filePath; this.logger = logger; this.logNonExisting = logNonExisting; @@ -39,9 +40,9 @@ public FilesystemPropertiesLoader(@NotNull String filePath, @NotNull ILogger log } else if (!f.isFile()) { if (logNonExisting) { logger.log( - SentryLevel.ERROR, - "Failed to load Sentry configuration since it is not a file or does not exist: %s", - filePath); + SentryLevel.ERROR, + "Failed to load Sentry configuration since it is not a file or does not exist: %s", + filePath); } } else if (!f.canRead()) { logger.log( From d35922867db96db3f350b9a266c2ad1ad9c9cad7 Mon Sep 17 00:00:00 2001 From: Alexander Dinauer Date: Mon, 24 Nov 2025 11:43:06 +0100 Subject: [PATCH 3/3] changelog --- CHANGELOG.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index bb788c78668..f2e64006f3c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,11 @@ # Changelog +## Unreleased + +### Fixes + +- Do not log if `sentry.properties` in rundir has not been found ([#4929](https://github.com/getsentry/sentry-java/pull/4929)) + ## 8.27.0 ### Features