Skip to content

Commit cd6bf1f

Browse files
committed
Merge branch 'main' into feedback-ui-2
# Conflicts: # CHANGELOG.md
2 parents 1bb4e34 + ae8e50c commit cd6bf1f

File tree

14 files changed

+778
-481
lines changed

14 files changed

+778
-481
lines changed

.github/ISSUE_TEMPLATE/BUG_REPORT.yml

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -51,16 +51,14 @@ body:
5151
label: 'How does your development environment look like?'
5252
description:
5353
'Output of the command `npx react-native@latest info` or manully describe your development environment?'
54-
placeholder: |-
55-
info Fetching system and libraries information...
56-
OS: OS version
57-
Node: Your version
58-
Yarn: Yarn version
59-
Expo SDK: Expo SDK version
60-
react: React version
61-
react-native: React Native version
62-
hermesEnabled: bool
63-
newArchEnabled: bool
54+
value: |-
55+
````
56+
⬇ Place the `npx react-native@latest info` output here. ⬇
57+
58+
59+
60+
61+
````
6462
6563
- type: textarea
6664
id: init
@@ -69,11 +67,13 @@ body:
6967
attributes:
7068
label: 'Sentry.init()'
7169
description: 'Code snipped of Sentry initialization from your application.'
72-
placeholder: |-
70+
value: |-
71+
````js
7372
Sentry.init({
7473
dsn: 'https://[email protected]/...'
7574
// other options
7675
});
76+
````
7777
7878
- type: textarea
7979
id: repro

.github/workflows/codeql-analysis.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ jobs:
4444

4545
# Initializes the CodeQL tools for scanning.
4646
- name: Initialize CodeQL
47-
uses: github/codeql-action/init@5f8171a638ada777af81d42b55959a643bb29017 # [email protected].12
47+
uses: github/codeql-action/init@1b549b9259bda1cb5ddde3b41741a82a2d15a841 # [email protected].13
4848
with:
4949
languages: ${{ matrix.language }}
5050
# If you wish to specify custom queries, you can do so here or in a config file.
@@ -55,7 +55,7 @@ jobs:
5555
# Autobuild attempts to build any compiled languages (C/C++, C#, or Java).
5656
# If this step fails, then you should remove it and run the build manually (see below)
5757
- name: Autobuild
58-
uses: github/codeql-action/autobuild@5f8171a638ada777af81d42b55959a643bb29017 # [email protected].12
58+
uses: github/codeql-action/autobuild@1b549b9259bda1cb5ddde3b41741a82a2d15a841 # [email protected].13
5959

6060
# ℹ️ Command-line programs to run using the OS shell.
6161
# 📚 https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions
@@ -66,4 +66,4 @@ jobs:
6666
# make bootstrap
6767
# make release
6868
- name: Perform CodeQL Analysis
69-
uses: github/codeql-action/analyze@5f8171a638ada777af81d42b55959a643bb29017 # [email protected].12
69+
uses: github/codeql-action/analyze@1b549b9259bda1cb5ddde3b41741a82a2d15a841 # [email protected].13

.github/workflows/e2e.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -151,8 +151,8 @@ jobs:
151151
react-native-build:
152152
name: Build RN ${{ matrix.rn-version }} ${{ matrix.rn-architecture }} ${{ matrix.engine }} ${{ matrix.platform }} ${{ matrix.build-type }} ${{ matrix.ios-use-frameworks }}
153153
runs-on: ${{ matrix.runs-on }}
154-
needs: [diff_check]
155-
if: ${{ needs.diff_check.outputs.skip_ci != 'true' }}
154+
needs: [diff_check, auth_token_check]
155+
if: ${{ needs.diff_check.outputs.skip_ci != 'true' && needs.auth_token_check.outputs.skip_ci != 'true' && !startsWith(github.ref, 'refs/heads/release/') }}
156156
env:
157157
RN_VERSION: ${{ matrix.rn-version }}
158158
RN_ENGINE: ${{ matrix.engine }}
@@ -387,7 +387,7 @@ jobs:
387387

388388
- name: Run tests on Android
389389
if: ${{ matrix.platform == 'android' }}
390-
uses: reactivecircus/android-emulator-runner@62dbb605bba737720e10b196cb4220d374026a6d # pin@v2.33.0
390+
uses: reactivecircus/android-emulator-runner@1dcd0090116d15e7c562f8db72807de5e036a4ed # pin@v2.34.0
391391
with:
392392
api-level: 30
393393
force-avd-creation: false

.github/workflows/native-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ jobs:
8888
sudo udevadm trigger --name-match=kvm
8989
9090
- name: Run connected tests
91-
uses: reactivecircus/android-emulator-runner@62dbb605bba737720e10b196cb4220d374026a6d #pin@v2.33.0
91+
uses: reactivecircus/android-emulator-runner@1dcd0090116d15e7c562f8db72807de5e036a4ed #pin@v2.34.0
9292
with:
9393
working-directory: packages/core/RNSentryAndroidTester
9494
api-level: 30

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
steps:
2020
- name: Get auth token
2121
id: token
22-
uses: actions/create-github-app-token@af35edadc00be37caa72ed9f3e6d5f7801bfdf09 # v1.11.7
22+
uses: actions/create-github-app-token@3ff1caaa28b64c9cc276ce0a02e2ff584f3900c5 # v2.0.2
2323
with:
2424
app-id: ${{ vars.SENTRY_RELEASE_BOT_CLIENT_ID }}
2525
private-key: ${{ secrets.SENTRY_RELEASE_BOT_PRIVATE_KEY }}

.github/workflows/sample-application.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -301,7 +301,7 @@ jobs:
301301

302302
- name: Run Android Tests on API ${{ env.ANDROID_API_LEVEL }}
303303
if: ${{ matrix.platform == 'android' }}
304-
uses: reactivecircus/android-emulator-runner@62dbb605bba737720e10b196cb4220d374026a6d # pin@v2.33.0
304+
uses: reactivecircus/android-emulator-runner@1dcd0090116d15e7c562f8db72807de5e036a4ed # pin@v2.34.0
305305
with:
306306
api-level: ${{ env.ANDROID_API_LEVEL }}
307307
force-avd-creation: false

CHANGELOG.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,19 @@
1212

1313
- Adds the `FeedbackButton` component that shows the Feedback Widget ([#4378](https://github.com/getsentry/sentry-react-native/pull/4378))
1414

15+
### Fixes
16+
17+
- Avoid silent failure when JS bundle was not created due to Sentry Xcode scripts failure ([#4690](https://github.com/getsentry/sentry-react-native/pull/4690))
18+
19+
### Dependencies
20+
21+
- Bump Bundler Plugins from v3.2.2 to v3.3.1 ([#4693](https://github.com/getsentry/sentry-react-native/pull/4693), [#4707](https://github.com/getsentry/sentry-react-native/pull/4707), [#4720](https://github.com/getsentry/sentry-react-native/pull/4720), [#4721](https://github.com/getsentry/sentry-react-native/pull/4721))
22+
- [changelog](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/main/CHANGELOG.md#331)
23+
- [diff](https://github.com/getsentry/sentry-javascript-bundler-plugins/compare/3.2.2...3.3.1)
24+
- Bump CLI from v2.42.4 to v2.43.0 ([#4692](https://github.com/getsentry/sentry-react-native/pull/4692))
25+
- [changelog](https://github.com/getsentry/sentry-cli/blob/master/CHANGELOG.md#2430)
26+
- [diff](https://github.com/getsentry/sentry-cli/compare/2.42.4...2.43.0)
27+
1528
## 6.11.0-beta.0
1629

1730
### Features

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
"devDependencies": {
3131
"@expo/swiftlint": "^0.57.1",
3232
"@naturalcycles/ktlint": "^1.13.0",
33-
"@sentry/cli": "2.42.4",
33+
"@sentry/cli": "2.43.0",
3434
"clang-format": "^1.8.0",
3535
"downlevel-dts": "^0.11.0",
3636
"google-java-format": "^1.4.0",

packages/core/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,9 @@
6565
"react-native": ">=0.65.0"
6666
},
6767
"dependencies": {
68-
"@sentry/babel-plugin-component-annotate": "3.2.2",
68+
"@sentry/babel-plugin-component-annotate": "3.3.1",
6969
"@sentry/browser": "8.54.0",
70-
"@sentry/cli": "2.42.4",
70+
"@sentry/cli": "2.43.0",
7171
"@sentry/core": "8.54.0",
7272
"@sentry/react": "8.54.0",
7373
"@sentry/types": "8.54.0",
@@ -81,7 +81,7 @@
8181
"@sentry-internal/eslint-config-sdk": "8.54.0",
8282
"@sentry-internal/eslint-plugin-sdk": "8.54.0",
8383
"@sentry-internal/typescript": "8.54.0",
84-
"@sentry/wizard": "4.5.0",
84+
"@sentry/wizard": "4.6.0",
8585
"@testing-library/react-native": "^12.7.2",
8686
"@types/jest": "^29.5.13",
8787
"@types/node": "^20.9.3",

packages/core/scripts/sentry-xcode.sh

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@ ARGS="$NO_AUTO_RELEASE $SENTRY_CLI_EXTRA_ARGS $SENTRY_CLI_RN_XCODE_EXTRA_ARGS"
2626

2727
REACT_NATIVE_XCODE_WITH_SENTRY="\"$SENTRY_CLI_EXECUTABLE\" react-native xcode $ARGS \"$REACT_NATIVE_XCODE\""
2828

29+
exitCode=0
30+
2931
if [ "$SENTRY_DISABLE_AUTO_UPLOAD" != true ]; then
3032
# 'warning:' triggers a warning in Xcode, 'error:' triggers an error
3133
set +x +e # disable printing commands otherwise we might print `error:` by accident and allow continuing on error
@@ -35,6 +37,7 @@ if [ "$SENTRY_DISABLE_AUTO_UPLOAD" != true ]; then
3537
else
3638
echo "error: sentry-cli - To disable source maps auto upload, set SENTRY_DISABLE_AUTO_UPLOAD=true in your environment variables. Or to allow failing upload, set SENTRY_ALLOW_FAILURE=true"
3739
echo "error: sentry-cli - $SENTRY_XCODE_COMMAND_OUTPUT"
40+
exitCode=1
3841
fi
3942
set -x -e # re-enable
4043
else
@@ -48,3 +51,5 @@ fi
4851
if [ -f "$SENTRY_COLLECT_MODULES" ]; then
4952
/bin/sh "$SENTRY_COLLECT_MODULES"
5053
fi
54+
55+
exit $exitCode

0 commit comments

Comments
 (0)