Merge pull request #426 from nateberkopec/fix-utf8-messages-in-exceptions

Fix UTF-8 conversion for bad exception messages

Author: nateberkopec

lib/raven/processor/utf8conversion.rb

@@ -5,6 +5,10 @@ def process(value)
         value.map { |v| process v }
       elsif value.is_a? Hash
         value.merge(value) { |_, v| process v }
+      elsif value.is_a?(Exception) && !value.message.valid_encoding?
+        clean_exc = value.class.new(clean_invalid_utf8_bytes(value.message))
+        clean_exc.set_backtrace(value.backtrace)
+        clean_exc
       else
         clean_invalid_utf8_bytes(value)
       end

spec/raven/processors/utf8conversion_spec.rb

@@ -24,6 +24,13 @@
       expect(results['invalid']).to eq("invalid utf8 string goes here")
     end
 
+    it "should cleanup invalid UTF-8 bytes in Exception messages" do
+      data = Exception.new("invalid utf8 string goes here\255".force_encoding('UTF-8'))
+
+      results = @processor.process(data)
+      expect(results.message).to eq("invalid utf8 string goes here")
+    end
+
     it 'should keep valid UTF-8 bytes after cleaning' do
       data = {}
       data['invalid'] = "한국, 中國, 日本(にっぽん)\255".force_encoding('UTF-8')