Skip to content

Commit ffb555e

Browse files
committed
Fix specs after restoring redis patch
1 parent 7efa6bc commit ffb555e

File tree

2 files changed

+23
-14
lines changed

2 files changed

+23
-14
lines changed

sentry-sidekiq/spec/sentry/sidekiq/cron/job_spec.rb

Lines changed: 17 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -109,10 +109,10 @@
109109

110110
expect(::Sidekiq::Queue.new.size).to eq(1)
111111
expect(transport.events.count).to eq(1)
112-
event = transport.events.last
113-
expect(event.spans.count).to eq(1)
114-
expect(event.spans[0][:op]).to eq("queue.publish")
115-
expect(event.spans[0][:data]['messaging.destination.name']).to eq('default')
112+
113+
span = transport.events.last.spans.detect { |span| span[:op] == "queue.publish" }
114+
expect(span[:op]).to eq("queue.publish")
115+
expect(span[:data]['messaging.destination.name']).to eq('default')
116116
end
117117

118118
it 'adds job to sidekiq within transaction' do
@@ -124,11 +124,19 @@
124124
expect(::Sidekiq::Queue.new.size).to eq(2)
125125
expect(transport.events.count).to eq(2)
126126
events = transport.events
127-
expect(events[0].spans.count).to eq(1)
128-
expect(events[0].spans[0][:op]).to eq("queue.publish")
129-
expect(events[0].spans[0][:data]['messaging.destination.name']).to eq('default')
130-
expect(events[1].spans.count).to eq(1)
131-
expect(events[1].spans[0][:op]).to eq("queue.publish")
127+
128+
span = events[0].spans.detect { |span| span[:op] == "queue.publish" }
129+
expect(span).not_to be_nil
130+
expect(span[:op]).to eq("queue.publish")
131+
expect(span[:data]['messaging.destination.name']).to eq('default')
132+
133+
span = events[1].spans.detect { |span| span[:op] == "queue.publish" }
134+
expect(span).not_to be_nil
135+
expect(span[:op]).to eq("queue.publish")
136+
137+
span = events[1].spans.detect { |span| span[:op] == "queue.publish" }
138+
expect(span).not_to be_nil
139+
expect(span[:op]).to eq("queue.publish")
132140
expect(events[1].spans[0][:data]['messaging.destination.name']).to eq('default')
133141

134142
expect(events[0].dynamic_sampling_context['trace_id']).to_not eq(events[1].dynamic_sampling_context['trace_id'])

sentry-sidekiq/spec/sentry/sidekiq/sentry_context_middleware_spec.rb

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -222,11 +222,12 @@ def ensure_queue_empty(queue, timeout: 0.1)
222222
transaction.finish
223223

224224
expect(transport.events.count).to eq(1)
225-
event = transport.events.last
226-
expect(event.spans.count).to eq(1)
227-
expect(event.spans[0][:op]).to eq("queue.publish")
228-
expect(event.spans[0][:data]['messaging.message.id']).to eq(message_id)
229-
expect(event.spans[0][:data]['messaging.destination.name']).to eq('default')
225+
226+
span = transport.events.last.spans.detect { |span| span[:op] == "queue.publish" }
227+
expect(span).not_to be_nil
228+
expect(span[:op]).to eq("queue.publish")
229+
expect(span[:data]['messaging.message.id']).to eq(message_id)
230+
expect(span[:data]['messaging.destination.name']).to eq('default')
230231
end
231232

232233
it "does not propagate headers with propagate_traces = false" do

0 commit comments

Comments
 (0)