address comments

Author: shruthilayaj

src/sentry/api/endpoints/organization_trace_item_stats.py

@@ -1,13 +1,13 @@
 import logging
 
+from rest_framework import serializers
 from rest_framework.request import Request
 from rest_framework.response import Response
 
 from sentry.api.api_owners import ApiOwner
 from sentry.api.api_publish_status import ApiPublishStatus
 from sentry.api.base import region_silo_endpoint
 from sentry.api.bases import NoProjects, OrganizationEventsV2EndpointBase
-from sentry.exceptions import InvalidSearchQuery
 from sentry.models.organization import Organization
 from sentry.search.eap.constants import SUPPORTED_STATS_TYPES
 from sentry.search.eap.resolver import SearchResolver
@@ -19,6 +19,13 @@
 logger = logging.getLogger(__name__)
 
 
+class OrganizationTraceItemsStatsSerializer(serializers.Serializer):
+    query = serializers.CharField(required=False)
+    statsType = serializers.ListField(
+        child=serializers.ChoiceField(SUPPORTED_STATS_TYPES), required=True
+    )
+
+
 @region_silo_endpoint
 class OrganizationTraceItemsStatsEndpoint(OrganizationEventsV2EndpointBase):
     publish_status = {
@@ -32,28 +39,20 @@ def get(self, request: Request, organization: Organization) -> Response:
         except NoProjects:
             return Response({"data": []})
 
-        stats_types = set(request.GET.getlist("statsType", default=["attributeDistributions"]))
-        if not stats_types:
-            raise InvalidSearchQuery(
-                f"Please specify `statsType`. Supported stats types are: {SUPPORTED_STATS_TYPES}."
-            )
-
-        for stats_type in stats_types:
-            if stats_type not in SUPPORTED_STATS_TYPES:
-                raise InvalidSearchQuery(
-                    f"{stats_type} is not a valid statsType. Please use one of the allowed stats types: {SUPPORTED_STATS_TYPES}."
-                )
+        serializer = OrganizationTraceItemsStatsSerializer(data=request.GET)
+        if not serializer.is_valid():
+            return Response(serializer.errors, status=400)
+        serialized = serializer.validated_data
 
         resolver_config = SearchResolverConfig()
         resolver = SearchResolver(
             params=snuba_params, config=resolver_config, definitions=SPAN_DEFINITIONS
         )
 
-        query = request.GET.get("query", "")
         stats_results = Spans.run_stats_query(
             params=snuba_params,
-            stats_types=stats_types,
-            query_string=query,
+            stats_types=serialized.get("statsType"),
+            query_string=serialized.get("query", ""),
             referrer=Referrer.API_SPANS_FREQUENCY_STATS_RPC.value,
             config=resolver_config,
             search_resolver=resolver,