Skip to content

Commit eb27bc5

Browse files
authored
fix(issues): Fix infinite react rerenders in issue list (#59169)
1 parent 034a5d9 commit eb27bc5

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

static/app/components/replays/useReplaysCount.tsx

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {useCallback, useMemo, useState} from 'react';
1+
import {useCallback, useEffect, useMemo, useState} from 'react';
22

33
import {DateString, IssueCategory, Organization} from 'sentry/types';
44
import {ApiQueryKey, useApiQuery} from 'sentry/utils/queryClient';
@@ -115,21 +115,22 @@ function useReplaysCount({
115115
}
116116
);
117117

118-
return useMemo(() => {
118+
useEffect(() => {
119119
if (isFetched) {
120-
const merged = {
120+
setLastData(last => ({
121121
...zeroCounts,
122-
...lastData,
122+
...last,
123123
...data,
124-
};
125-
setLastData(merged);
126-
return merged;
124+
}));
127125
}
126+
}, [isFetched, zeroCounts, data]);
127+
128+
return useMemo<CountState>(() => {
128129
return {
129130
...lastData,
130131
...data,
131132
};
132-
}, [isFetched, zeroCounts, lastData, data]);
133+
}, [lastData, data]);
133134
}
134135

135136
function makeReplayCountsQueryKey({

0 commit comments

Comments
 (0)